Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Signup Url not found on signing up #116

Open
1 of 2 tasks
mtahafarooq opened this issue Apr 3, 2019 · 7 comments
Open
1 of 2 tasks

Signup Url not found on signing up #116

mtahafarooq opened this issue Apr 3, 2019 · 7 comments

Comments

@mtahafarooq
Copy link
Contributor

mtahafarooq commented Apr 3, 2019

I'm submitting a

(Check one with "x" from given options)

  • Bug report
  • Feature request

Current behavior

When a user fills the required fields on the signup form on auth/signup and clicks the submit button, it doesn't proceed forward, checking the console shows that the endpointsService is not present on the self object.

Expected behavior

Upon clicking the signup button after filling the required fields, it should send request to backend without any errors.

Steps to reproduce

  1. Launch the application
  2. Click on the Signup button to navigate to signup page
  3. Fill the required fields
  4. Click the signup button
  5. It won't proceed further as it should

Related screenshots

gsoc1

Other information

System information

Ubuntu 18.04 LTS
Node.JS: v8.12.0

@mtahafarooq
Copy link
Contributor Author

I've fixed it, and I'm going to open a PR soon, can you assign this to me?

@Shekharrajak
Copy link
Member

Feel free to open PR and refer the issue in PR description, so that everyone can see there is PR related to this issue .

@Shekharrajak
Copy link
Member

Shekharrajak commented Apr 3, 2019

So what we discussed in gitter channel is :

backend server should be present and run it in docker compose : https://github.com/Cloud-CV/EvalAI#installation-instructions

Once you started the backend server in docker container, we can use it in Angular application by editiing the environment variable, present in environment/ folder :

export const environment = {
  production: false,
  api_endpoint: 'http://localhost:8000/api/'
};

Also I feel, environment folder should have proper named file.

Update - api_endpoint should be localhost:8000/api when you are using local backend server.

@mtahafarooq
Copy link
Contributor Author

@Shekharrajak I already have the same api_endpoint in the codebase, but the problem is that the server running there doesn't response with Access-Control-Allow-Origin header to my pre-flight request.
Why is this happening? Can you please explain?

For testing, I've replaced it with localhost:8000/api to use the local server and it works just fine.

@Shekharrajak
Copy link
Member

Actually you need to use :

export const environment = {
  production: false,
  api_endpoint: 'http://localhost:8000/api/'
};

I mistakenly pasted worng api_endpoint, now I updated it.

@Shekharrajak
Copy link
Member

Shekharrajak commented Apr 3, 2019

@RishabhJain2018 , shouldn't it work for 'http://staging.evalai.cloudcv.org:8000/api/' end-point as well ? Are you aware of Access-Control-Allow-Origin issue(when running Angular application locally) for this staging endpoint?

@mtahafarooq
Copy link
Contributor Author

@Shekharrajak understood.

So, I made the PR, and it was failing a test case, I've fixed that as well (just needed to add the service in spec file providers array). And the Travis CI has passed all the test cases.

#117

Now you will assign a reviewer yourself right?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants