Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible return type ClickHouseConnectionManager.execute #161

Closed
PrVrSs opened this issue Jun 12, 2023 · 2 comments
Closed

Incompatible return type ClickHouseConnectionManager.execute #161

PrVrSs opened this issue Jun 12, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@PrVrSs
Copy link
Contributor

PrVrSs commented Jun 12, 2023

Describe the bug

run_hooks method raise exception: Attribute: 'str' object has no attribute '_message'.
https://github.com/dbt-labs/dbt-core/blob/v1.4.1/core/dbt/task/run.py#L366

Steps to reproduce

  1. Create macro
{% macro parity_str_udf %}

CREATE FUNCTION parity_str AS (n) -> if(n % 2, 'odd', 'even');

{% endmacro %)
  1. dbt run

Expected behaviour

No exception.

Code examples, such as models or profile settings

dbt_project.yml

on-run-start:
- {{ parity_str_udf() }}

Configuration

Environment

  • dbt version: 1.4.x
  • dbt-clickhouse version: 1.4.2

ClickHouseConnectionManager.execute must return: Tuple[AdapterResponse, agate.Table]
Now: Tuple[str, agate.Table]

@PrVrSs PrVrSs added the bug Something isn't working label Jun 12, 2023
@genzgd
Copy link
Contributor

genzgd commented Jun 12, 2023

Thanks for your report and PR -- this seems like it would have been broken for quite some time, do you why this issue is just showing up now?

@PrVrSs
Copy link
Contributor Author

PrVrSs commented Jun 12, 2023

I don't know. I recently started using dbt.

@genzgd genzgd closed this as completed Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants