Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements #57

Closed
rpopescu opened this issue Oct 8, 2020 · 0 comments
Closed

Performance improvements #57

rpopescu opened this issue Oct 8, 2020 · 0 comments

Comments

@rpopescu
Copy link
Contributor

rpopescu commented Oct 8, 2020

  • add bool WireFormat::SkipString(CodedInputStream*) (used below);
  • Client::Impl::ReceiveData() uses SkipString to skip over an unused string in the input, instead of creating a std::string, reading into it, then discarding it;
  • Client::Impl::ReadBlock(...) reuses the std::string variables name and type for all columns, instead of allocating these two std::strings for each column;
  • Client::Impl::Insert(...) builds the fields_section more efficiently, directly from the block, without creating and copying from the block into a std::vector<std::string>, and then writing to std::stringstream from it.
@Enmk Enmk closed this as completed in b0f2d60 Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant