Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ping checks status_code should be status #96

Closed
bnomis opened this issue Jan 16, 2023 · 1 comment
Closed

ping checks status_code should be status #96

bnomis opened this issue Jan 16, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@bnomis
Copy link

bnomis commented Jan 16, 2023

This code in httpclient.py/ping()

return 200 <= response.status_code < 300

should be

return 200 <= response.status < 300
@genzgd
Copy link
Collaborator

genzgd commented Jan 16, 2023

Thanks for the report! I'll release v0.5.1 with a fix shortly.

@genzgd genzgd closed this as completed Jan 16, 2023
@genzgd genzgd added the bug Something isn't working label Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bnomis @genzgd