Add profile event in hedged requests and change timeout from sec to ms. #21886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… requests and better process receiving packets
robot-clickhouse
added
the
pr-improvement
alexey-milovidov
added
the
pr-must-backport
akuzm
reviewed
Mar 18, 2021
| @@ -4,8 +4,8 @@ | |||
| <default> | |||
| <load_balancing>in_order</load_balancing> | |||
| <max_parallel_replicas>2</max_parallel_replicas> | |||
| <hedged_connection_timeout>100</hedged_connection_timeout> | |||
| <receive_data_timeout>2</receive_data_timeout> | |||
| <hedged_connection_timeout_ms>100</hedged_connection_timeout_ms> | |||
There was a problem hiding this comment.
This one should be increased, right?
There was a problem hiding this comment.
Connection timeout was already in ms.
akuzm
approved these changes
Mar 18, 2021
|
Many integration tests from test_distributed_respect_user_timeouts are flaky under tsan, can this be related? |
I see the same problem on master, I think it's not related to this PR. |
|
OK, let's merge then. |
This was referenced Apr 7, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Apr 7, 2021
…nge timeout from sec to ms.
kitaisreal
added a commit
that referenced
this pull request
Apr 8, 2021
Backport #21886 to 21.3: Add profile event in hedged requests and change timeout from sec to ms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add profile event HedgedRequestsChangeReplica, change read data timeout from sec to ms.
Detailed description / Documentation draft:
HedgedRequestsChangeReplica event counts the total number of times when a change replica timeout has been alarmed. Change
read_data_timeouttimeout from sec to ms, add_msending to the timeouts. Add better processing the case whenmax_parallel_replicas> 1 but there is no way to sample data in this query.