Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filesystem_caches_path in the configuration should be defined by default #57825

Closed
alexey-milovidov opened this issue Dec 13, 2023 · 1 comment · Fixed by #58869
Closed

filesystem_caches_path in the configuration should be defined by default #57825

alexey-milovidov opened this issue Dec 13, 2023 · 1 comment · Fixed by #58869
Assignees

Comments

@alexey-milovidov
Copy link
Member

  1. Allow relative paths for the value of filesystem_caches_path. It should be relative to path.
  2. Set it to cache by default in clickhouse-server's configuration to avoid a minor vulnerability with creating tables with dynamic disks.
  3. Make sure it applies to dynamic disks, but statically configured paths are still allowed to point anywhere.
  4. Make sure clickhouse-local still allows dynamic disks to have paths point anywhere.
  5. Update the code of ClickBench, related to clickhouse-web.
@kssenii kssenii self-assigned this Dec 13, 2023
@kssenii
Copy link
Member

kssenii commented Jan 16, 2024

As filesystem_caches_path affects not only dynamic disks, but all disks, I'd rather not set it in default config, but do this #58869 (See PR description).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants