Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dry Held-Suarez run script #798

Merged
merged 1 commit into from
May 20, 2024
Merged

Add dry Held-Suarez run script #798

merged 1 commit into from
May 20, 2024

Conversation

LenkaNovak
Copy link
Collaborator

@LenkaNovak LenkaNovak commented May 16, 2024

closes #759

  • I have read and checked the items on the review checklist.

Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the low resolution intended? Otherwise the config file looks good to me. I also think it may be confusing for new users that you need to use coupler modules and functions to run held suarez, but that's probably a separate issue.

experiments/ClimaEarth/run_dry_held_suarez.jl Outdated Show resolved Hide resolved
@LenkaNovak
Copy link
Collaborator Author

Is the low resolution intended? Otherwise the config file looks good to me. I also think it may be confusing for new users that you need to use coupler modules and functions to run held suarez, but that's probably a separate issue.

Thank you for the review. Yeah, we’ll want to contain all the hierarchy experiment setups in one file for each simulation and with the lowest possible resolution. This is should be sufficient to showcase the modularity of the code with minimal overhead, which is the intent of this paper. We will be showing the more realistic runs with the AMIP setup with data in your paper I guess. :) As for the path of the runscripts, we may eventually move all our hierarchy run scripts into one separate dir, but while we're adding all the cases iteratively, we decided to keep them all in the same dir as the amip run.

@szy21
Copy link
Member

szy21 commented May 20, 2024

Thank you for the review. Yeah, we’ll want to contain all the hierarchy experiment setups in one file for each simulation and with the lowest possible resolution. This is should be sufficient to showcase the modularity of the code with minimal overhead, which is the intent of this paper. We will be showing the more realistic runs with the AMIP setup with data in your paper I guess. :) As for the path of the runscripts, we may eventually move all our hierarchy run scripts into one separate dir, but while we're adding all the cases iteratively, we decided to keep them all in the same dir as the amip run.

Sounds good! For the comment on coupler modules I meant it might be confusing for new users that we need to have e.g.

using ClimaCoupler.FieldExchanger:
    import_atmos_fields!, import_combined_surface_fields!, update_model_sims!, reinit_model_sims!, step_model_sims!
using ClimaCoupler.FluxCalculator:
    PartitionedStateFluxes,
    CombinedStateFluxes,
    combined_turbulent_fluxes!,
    MoninObukhovScheme,
    partitioned_turbulent_fluxes!,
    water_albedo_from_atmosphere!
using ClimaCoupler.Interfacer: CoupledSimulation, SurfaceStub, get_field, update_field!
using ClimaCoupler.Regridder
using ClimaCoupler.Regridder: update_surface_fractions!, combine_surfaces!, binary_mask

even for a simple case like dry Held Suarez. But we don't need to address it now. Are these necessary though?

@LenkaNovak
Copy link
Collaborator Author

Thank you for the review. Yeah, we’ll want to contain all the hierarchy experiment setups in one file for each simulation and with the lowest possible resolution. This is should be sufficient to showcase the modularity of the code with minimal overhead, which is the intent of this paper. We will be showing the more realistic runs with the AMIP setup with data in your paper I guess. :) As for the path of the runscripts, we may eventually move all our hierarchy run scripts into one separate dir, but while we're adding all the cases iteratively, we decided to keep them all in the same dir as the amip run.

Sounds good! For the comment on coupler modules I meant it might be confusing for new users that we need to have e.g.

using ClimaCoupler.FieldExchanger:
    import_atmos_fields!, import_combined_surface_fields!, update_model_sims!, reinit_model_sims!, step_model_sims!
using ClimaCoupler.FluxCalculator:
    PartitionedStateFluxes,
    CombinedStateFluxes,
    combined_turbulent_fluxes!,
    MoninObukhovScheme,
    partitioned_turbulent_fluxes!,
    water_albedo_from_atmosphere!
using ClimaCoupler.Interfacer: CoupledSimulation, SurfaceStub, get_field, update_field!
using ClimaCoupler.Regridder
using ClimaCoupler.Regridder: update_surface_fractions!, combine_surfaces!, binary_mask

even for a simple case like dry Held Suarez. But we don't need to address it now. Are these necessary though?

Ahh I see. Yes, we should prune these actually.

paths

pip

io_helpers

configs

6h output

Array

SVector

SVector

SVector

import

clean driver

format

rev

rev

add hs to ci runs

pip

pip
@LenkaNovak LenkaNovak enabled auto-merge May 20, 2024 09:10
@LenkaNovak LenkaNovak merged commit ab243e2 into main May 20, 2024
7 checks passed
- label: "Dry Held Suarez"
key: "dry_held_suarez"
command:
- sed 's/t_end = "1000days"/t_end = "1days"/' experiments/ClimaEarth/run_dry_held_suarez.jl > experiments/ClimaEarth/run_dry_held_suarez_modified.jl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this line of the command doing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hierarchies: Dry Held-Suarez driver
3 participants