-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dry Held-Suarez run script #798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the low resolution intended? Otherwise the config file looks good to me. I also think it may be confusing for new users that you need to use coupler modules and functions to run held suarez, but that's probably a separate issue.
Thank you for the review. Yeah, we’ll want to contain all the hierarchy experiment setups in one file for each simulation and with the lowest possible resolution. This is should be sufficient to showcase the modularity of the code with minimal overhead, which is the intent of this paper. We will be showing the more realistic runs with the AMIP setup with data in your paper I guess. :) As for the path of the runscripts, we may eventually move all our hierarchy run scripts into one separate dir, but while we're adding all the cases iteratively, we decided to keep them all in the same dir as the amip run. |
Sounds good! For the comment on coupler modules I meant it might be confusing for new users that we need to have e.g.
even for a simple case like dry Held Suarez. But we don't need to address it now. Are these necessary though? |
Ahh I see. Yes, we should prune these actually. |
paths pip io_helpers configs 6h output Array SVector SVector SVector import clean driver format rev rev add hs to ci runs pip pip
- label: "Dry Held Suarez" | ||
key: "dry_held_suarez" | ||
command: | ||
- sed 's/t_end = "1000days"/t_end = "1days"/' experiments/ClimaEarth/run_dry_held_suarez.jl > experiments/ClimaEarth/run_dry_held_suarez_modified.jl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this line of the command doing?
closes #759