Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cleaned temporal albedo dataset #626

Closed
juliasloan25 opened this issue Feb 14, 2024 · 1 comment
Closed

use cleaned temporal albedo dataset #626

juliasloan25 opened this issue Feb 14, 2024 · 1 comment
Labels
🍃 leaf Issue coupled to a PR 💰 Grab Bag

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Feb 14, 2024

The data we've been using for our temporal map albedo has NaNs in the northern latitudes. I've cleaned this dataset to replace those values with 1s, since in this snowy area we would expect larger latitudes. This is an oversimplification and we should find a better solution, but for now we can use this cleaned data to avoid handling NaNs even more incorrectly.

We should also use NCDatasets.nomissing when we read in data from NetCDF files (see docs here). This should fix the error ERROR: LoadError: MethodError: Cannot convert an object of type Missing to an object of type Float64 we see sometimes

This was done for ClimaLand in CliMA/ClimaLand.jl#482

@juliasloan25
Copy link
Member Author

We don't download the dataset directly, but rather get it from ClimaLand via a BulkAlbedoTemporal call. So we don't need to make this change in the coupler

@juliasloan25 juliasloan25 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍃 leaf Issue coupled to a PR 💰 Grab Bag
Projects
None yet
Development

No branches or pull requests

2 participants