Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interpol bug #372

Closed
2 tasks done
juliasloan25 opened this issue Aug 2, 2023 · 0 comments · Fixed by #373
Closed
2 tasks done

interpol bug #372

juliasloan25 opened this issue Aug 2, 2023 · 0 comments · Fixed by #373
Assignees
@juliasloan25
Labels
bug Something isn't working

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Aug 2, 2023 •
edited
Loading

In ClimaLSM's implementation of BCReader.interpol, we found an error in the logic of the math (see CliMA/ClimaLand.jl#282).

Closed by #373

Content

  • fix logic in interpol
  • add unit tests for this function
    • use ClimaLSM tests as template
@juliasloan25 juliasloan25 added the bug Something isn't working label Aug 2, 2023
@juliasloan25 juliasloan25 self-assigned this Aug 2, 2023
@juliasloan25 juliasloan25 mentioned this issue Aug 2, 2023
Merged
3 tasks
@bors bors bot closed this as completed in #373 Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliasloan25 juliasloan25

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix BCReader.interpol CliMA/ClimaCoupler.jl
1 participant
@juliasloan25