Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move push_pull!.jl functionality to src/ #321

Closed
8 tasks done
LenkaNovak opened this issue Jun 12, 2023 · 0 comments · Fixed by #320
Closed
8 tasks done

Move push_pull!.jl functionality to src/ #321

LenkaNovak opened this issue Jun 12, 2023 · 0 comments · Fixed by #320
Assignees

Comments

@LenkaNovak
Copy link
Collaborator

LenkaNovak commented Jun 12, 2023

To be able to update for the new ClimaAtmos release, we needed to change our flux calculation and field passing interface. This is done here by moving and generalizing the push_pull!.jl code to src by setting up a FieldExchange and FluxCalculator modules. This also the last step needed before implementing the partial flux calculation PR.

Components

  • setup FieldExchange and FluxCalculator code (non-modularized - easier testing)
  • ensure slab planet and AMIP run as in the main
  • ensure AMIP runs
  • modularize
  • add unit tests
  • add docs

QA

  • reproducible results compared to Buildkite (small changes expected, due to different order of model initialization)
Screen Shot 2023-06-13 at 9 38 48 AM Screen Shot 2023-06-13 at 9 39 07 AM
  • no substantial performance deterioration
Screen Shot 2023-06-13 at 9 41 31 AM
@LenkaNovak LenkaNovak self-assigned this Jun 12, 2023
This was referenced Jun 12, 2023
@bors bors bot closed this as completed in #320 Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant