Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add accountChooser Url support #244

Open
FossPrime opened this issue Oct 8, 2021 · 0 comments
Open

[FR] Add accountChooser Url support #244

FossPrime opened this issue Oct 8, 2021 · 0 comments

Comments

@FossPrime
Copy link

FossPrime commented Oct 8, 2021

Are you open to a PR for supporting accountChooserUrl in IDP? I understand it's not strictly part of the SAML standard, hence the non-conformant naming.

Problem

There is an issue with Google's SAML implementation... it doesn't support force_authn. Which means if the only account you're logged into is a personal account... their saml endpoint will return a dead end 403 error.

Solution

The workaround, aside from begging for force_authn support, is to use the AccountChooser url... but that cant be done at the idp.sso_login_url or loginRequestOptions level, as the SAML2Request parameter needs to be encoded into the continue parameter...

I think that's a better implementation than the googleAuth: true the passport-saml fork did.

Alternative

Hijacking the 302 redirect after create_login_request_url... which is easier said than done as higher level modules sometimes need to support Express, Koa, Native, etc router implementations.

Source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant