Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more filtering options #59

Closed
ClementTsang opened this issue Mar 1, 2020 · 0 comments · Fixed by #139
Closed

Add more filtering options #59

ClementTsang opened this issue Mar 1, 2020 · 0 comments · Fixed by #139
Assignees
Labels
feature Requests for a new feature.

Comments

@ClementTsang
Copy link
Owner

ClementTsang commented Mar 1, 2020

Describe the feature request

Why should we consider this feature request? Describe why, and/or how you think this feature will solve the issue, or overall improve the application:

More filtering options could be nice. For example, allow filtering things so we only see processes that are >1% CPU usage.

Additional context/details

Provide any additional context or details here. What needs to be done, why, etc:

Adding this might require rethinking how we currently deal with searching by x category. Since we currently only have two categories - PID and name - it's easy, just make TAB a toggle.

This changes if we add multiple search categories. How do we manage which thing we're searching? Do we stay backwards-compatible? Or just replace it with an entirely new system? (I'm leaning towards the latter tbh)

  • One possible idea (that I personally don't really like but it's the easiest) is we search based on some prefix. Want CPU% filtering? Do some query like cpu%<5. This is similar to how top does it. Why don't I like it? I think it's too verbose, personally, and maybe unintuitive?

  • Another is to add some kinda TUI selector within the search bar to allow for specific types of searching for each category. So for example, ctrl-c gives CPU , ctrl-m gives memory, etc. This is probably one of the better ways (IMO). Would need some redesigning of the search bar though as it might be too unintuitive? Unless I literally show all hotkeys there. Also, I'm starting to overload the whole ctrl-x space so that might be a thing to consider.

  • Just make tab and ctrl-tab to cycle through. Easy to do I guess but might be kinda dumb tbh? idk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Requests for a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant