Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor currently can go off screen without repositioning. #41

Closed
ClementTsang opened this issue Feb 27, 2020 · 2 comments · Fixed by #50
Closed

Cursor currently can go off screen without repositioning. #41

ClementTsang opened this issue Feb 27, 2020 · 2 comments · Fixed by #50
Assignees
Labels
bug Something isn't working the way that is expected.

Comments

@ClementTsang
Copy link
Owner

Describe the bug

A clear and concise description of what the bug is and what the expected behaviour was:

Due to us not repositioning to where the cursor is, if you put a huge query and scroll left, it will not automatically redraw to where the cursor is.

To reproduce

Steps on how to reproduce the behaviour:

  1. Type in a huge message
  2. Scroll left until you go off screen

Screenshots

If applicable, add screenshots to help explain your problem:

Platform

Provide information on:

Operating System: AL

Terminal: Kitty

Any other relevant information (more details are always good!):

Additional context

If anything hasn't been covered by the above categories, state it down here:

@ClementTsang ClementTsang added the bug Something isn't working the way that is expected. label Feb 27, 2020
@ClementTsang ClementTsang self-assigned this Feb 27, 2020
@ClementTsang
Copy link
Owner Author

Logic to solve this can follow the same logic as my scrollling trick. Just need to rewrite it to fit the requirements of a cursor (LR vs UD, naming, etc.)

@ClementTsang ClementTsang changed the title Scroll currently can go off screen without repositioning. Cursor currently can go off screen without repositioning. Feb 28, 2020
@ClementTsang ClementTsang mentioned this issue Feb 28, 2020
6 tasks
@ClementTsang
Copy link
Owner Author

Almost lied to myself there, there was a bit of work needed to be done to go from the existing byte-based cursor position to adding an extra char based one in order to properly sync up the canvas and app state.

Testing with unicode (especially stuff like CJK) is a MUST.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working the way that is expected.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant