-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate a default config file #37
Comments
If you accept contributions I would like to tackle this issue, seems like a good first issue |
Sure! I thought about doing this originally but wasn't sure what a good way to tackle this was. |
The approach I have been using in my projects that use config files is the following:
What do you think? EDIT: meant override, not overwrite |
While I like the idea behind this part, it's kinda 50/50 for me. I'm just not 100% on setting values for the user without them explicitly knowing that they're set, especially since if an option is set to true on the config file, then there's no way to actually turn the thing off from the command line - only on. So either notifying the user what values are set, or just (imo the easier solution I guess) leaving it default entirely if we create one is probably what I would rather do. The rest of it I like though. |
What I meant by overwrite the config with commandline flags is what is already currently implemented. If my config file says the temperature should be Kelvin, but I run bottom with |
Ah, okay. Thought you meant something like, if you run say Looks good then! |
Describe the feature request
Perhaps it is a good idea to create a default config file (same as the one that is bundled into release) in the config path (as specified here) if it does not exist?
Additional context/details
Why it would be beneficial:
btm
once and you can go straight to configuring with lets sayvim ~/.config/bottom/bottom.toml
The text was updated successfully, but these errors were encountered: