Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverted behavior of 'hide_avg_cpu' flag in config file #325

Closed
seifrox opened this issue Nov 25, 2020 · 1 comment · Fixed by #327
Closed

Inverted behavior of 'hide_avg_cpu' flag in config file #325

seifrox opened this issue Nov 25, 2020 · 1 comment · Fixed by #327
Labels
bug Something isn't working the way that is expected.

Comments

@seifrox
Copy link

seifrox commented Nov 25, 2020

Describe the bug

The average CPU is not hidden when hide_avg_cpu = true is provided in the config file, rather the behavior is inverted. When hide_avg_cpu = false is provided the average is actually CPU hidden.

To reproduce

Steps on how to reproduce the behaviour:

create a ~/.config/bottom/bottom.toml config file with the following content:

[flags]
# Whether to hide the average cpu entry.
hide_avg_cpu = true

bottom version (use btm -V)

bottom 0.5.1

bottom config file (if one is used)

[flags]
# Whether to hide the average cpu entry.
hide_avg_cpu = true

Installation method

curl -LO https://github.com/ClementTsang/bottom/releases/download/0.5.1/bottom_0.5.1_amd64.deb
sudo dpkg -i bottom_0.5.1_amd64.deb

Platform

Operating system and OS version:
Distributor ID: Ubuntu
Description: Ubuntu 20.04.1 LTS
Release: 20.04
Codename: focal

Terminal (i.e. urxvt, kitty, etc.):
kitty 0.15.0 created by Kovid Goyal

Shell (i.e. zsh, bash, etc.):
fish, version 3.1.0

@seifrox seifrox added the bug Something isn't working the way that is expected. label Nov 25, 2020
@ClementTsang
Copy link
Owner

Yep, you're right, seems like I forgot to fix this when I switched from show_avg_cpu to hide_avg_cpu.

Will deploy a release with a fix in a bit, hopefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working the way that is expected.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants