Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit maximizing to make it more useful, put in more info #19

Open
19 tasks
ClementTsang opened this issue Feb 23, 2020 · 7 comments
Open
19 tasks

Revisit maximizing to make it more useful, put in more info #19

ClementTsang opened this issue Feb 23, 2020 · 7 comments
Assignees
Labels
feature Requests for a new feature.

Comments

@ClementTsang
Copy link
Owner

ClementTsang commented Feb 23, 2020

Describe the feature request

Maximizing is currently fine in that it literally just does that - maximize.

Now, time to take a look at part 2 - adding more details if possible. Stuff that can't fit on the normal size.

Additional context

We can also (I guess) use this to extend some other widgets. Or at least try (I guess this is gonna push back the release pretty hard but oh well, might as well do it now).

I guess a general good idea is to see what stuff like top has, and see if we can also display similar data. Whether all of these will be available cross-platform is another story.

...also I might rebind the maximize key to M or even m. Just gonna put that out there. Enter is too useful of a key and makes sense for other tasks IMO.

Possible candidates:

CPU

Overall I think I might switch to heim purely for functionality reasons first, then go about implementing extra details. I wouldn't graph most of these but just display them, maybe a Paragraph widget or something.

  • Frequency (heim and sysinfo both support this)
  • CTX-switch and interrupts (heim)
  • Software-interrupts (linux only, heim)
  • Load average (sysinfo handles this, not sure if heim does. But if we want to switch to heim...)
  • Apparently someone is interested in CPI. I guess this is doable... maybe? I don't know.
  • At least for linux, heim does support all cpu times. I can display this (per cpu + avg) if that's desirable.
    • Perhaps those cpu times... per second (like delta / s). I don't know.
  • Someone also seems interested in scheduler latency. I don't... really know how easy that will be to do on Linux, let alone cross-platform. It seems we can do something along the lines of this calculation for Linux?

RAM

  • Could be interesting to display stuff like page faults? The main problem is that neither heim nor sysinfo support this - and this might end up being a Linux-specific implementation for a while (macOS and Windows are ??? for me as of writing this). Which I kinda hate. It's definitely doable though... I think.
  • buff/cache values. heim.

Processes

Some of these might just become columns overall but given a later priority in terms of drawing.

Also something unrelated is allowing disabling certain columns (some people probably won't care about this (and other extra columns)).

  • Give an easy count to how many tasks, task state (sleep/zombie/running/stopped)
  • Add process state.
  • Showing actual values of mem usage?
  • Virtual memory?
  • I/O stats a la IO stats per process #58 (though that might just go there in general). Doing this will close that task too.

Network

Temps

  • As mentioned, graph this data. Scale it to... I think 100 degrees is fine? Maybe set it to like -10 to 110 C (dunno how many people would need subzero let's be real)

Disks

  • As mentioned, graph IO/s. Probably range logarithmically from 0B/s to like... 10GB/s? Maybe a bit higher? Any more seems like overkill quite frankly. Maybe 1TB/s?
@ClementTsang ClementTsang added the feature Requests for a new feature. label Feb 23, 2020
@ClementTsang ClementTsang self-assigned this Feb 23, 2020
@ClementTsang ClementTsang changed the title Revisit maximizing Revisit maximizing to make it more useful Mar 1, 2020
@ClementTsang ClementTsang changed the title Revisit maximizing to make it more useful Revisit maximizing to make it more useful, put in more info Mar 1, 2020
@ClementTsang
Copy link
Owner Author

Note to self, probably going to break this up into multiple parts and potentially stretch it across multiple versions. It's currently a bit too large in terms of scope as one issue IMO.

@ClementTsang
Copy link
Owner Author

Pushing to 0.4.0, going to split up too.

@kaushalyap
Copy link

@ClementTsang I cannot see memory legend in memory block, should I file a bug?

Screenshot from 2020-04-02 12-14-08

@kaushalyap
Copy link

@ClementTsang Why the memory legend not shown in the memory block? should I file a bug?

@ClementTsang
Copy link
Owner Author

ClementTsang commented Apr 14, 2020

@ClementTsang Why the memory legend not shown in the memory block? should I file a bug?

@kaushalyap This is due to the TUI library I'm using automatically hiding legends on certain heights. This should be resolved when the library updates, as that will allow more controllable legends.

See: fdehau/tui-rs#221

EDIT: Just for documentation purposes, fixed with PR #123

@tommywalkie
Copy link

@ClementTsang Recently tried Bottom and I'm enjoying it.
I came here while looking for a way to display memory usage value instead of percentages.

Showing actual values of mem usage?

Otherwise, nice work !

@ClementTsang
Copy link
Owner Author

ClementTsang commented May 21, 2020

@tommywalkie Yeah, planning on adding that in (and eventually making stuff like the process widget more configurable in letting you choose what things you want to prioritize in seeing/see in general). Just gotta get some time and finish some current tasks.

And thanks, glad you like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Requests for a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants