Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate issue status #32

Closed
NasAmin opened this issue Oct 16, 2020 · 3 comments
Closed

Validate issue status #32

NasAmin opened this issue Oct 16, 2020 · 3 comments

Comments

@NasAmin
Copy link
Contributor

NasAmin commented Oct 16, 2020

Description

When pushing changes for a jira issue, sometimes engineers push changes for stories that are already closed or not pulled into the active sprint.

Reasons for issue status validation:

  • Just being humans. engineers might have forgotten to put their story in the correct status.
  • Someone else closed your story e.g. your product owner but you aren't aware.
  • Someone pulled the story out of your active backlog/sprint as a result of prioritisation.
  • Process requirements within your organisation to follow certain workflows based on jira issue status.

Proposal

I propose introducing two new inputs into jira-lint.

validate_issue_status
This should enable validation of jira issue status. By default this validation should be off.

allowed_issue_statuses
This should be used in conjunction with validate_issue_status. When validate_issue_status is true, the allowed_issue_Statuses should be uses as a list of acceptable jira issue statuses provided by the consumer of jira-lint. If validation is enabled, jira-lint should compare the current status of the detected issue with the allowed_issue_statuses. If no match is found then jira-lint should fail the status check and put a comment on the PR with what is wrong.

Example comment when status validation fails

💔 The detected issue is not in one of the allowed statuses 💔

Detected Status Done
Allowed Statuses In-Progress,In-Review ✔️

Please ensure your jira story is in one of the allowed statuses

@NasAmin
Copy link
Contributor Author

NasAmin commented Oct 16, 2020

Please review #33

@NasAmin
Copy link
Contributor Author

NasAmin commented Dec 24, 2020

PR #33 merged. @rheaditi @loftykhanna thanks for reviewing and merging the PR.
Can the changes be released as a new version please?

@NasAmin
Copy link
Contributor Author

NasAmin commented Dec 28, 2020

Closing this issue as the changes have been released from #33

https://github.com/ClearTax/jira-lint/releases/tag/0.1.0

@NasAmin NasAmin closed this as completed Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant