Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce UITextView support #2

Open
2 tasks
DivineDominion opened this issue May 16, 2024 · 2 comments
Open
2 tasks

Introduce UITextView support #2

DivineDominion opened this issue May 16, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DivineDominion
Copy link
Contributor

DivineDominion commented May 16, 2024

Since UITextView and NSTextView share most of the underpinnings, including being backed by UTF-16 NSStrings, adding UIKit support should consist of either

  • adding an adapter like NSTextViewBuffer but for UITextView,
  • use a TextViewBuffer (sans prefix) for both.

With conditional compilation, #if os(macOS) around the NSTextView property declaration and initializer should do the trick iff the API really is exactly the same.

  • Add iOS, iPad, ... as deployment targets
  • Re-use or add tests for UITextView
@DivineDominion DivineDominion added enhancement New feature or request good first issue Good for newcomers labels May 16, 2024
@DivineDominion DivineDominion changed the title Introduce UITextView conformance Introduce UITextView support May 22, 2024
@DivineDominion
Copy link
Contributor Author

I prepared conditional compilation in 6413c4f

@ikelax
Copy link
Contributor

ikelax commented May 31, 2024

I want to work on this. However, it will take me some time, because I am quite busy currently, and I will likely need help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants