Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] Issue 22: Missing first-level heading (Closed Page) #80

Closed
NewJerseyStyle opened this issue Oct 31, 2024 · 2 comments
Closed

[a11y] Issue 22: Missing first-level heading (Closed Page) #80

NewJerseyStyle opened this issue Oct 31, 2024 · 2 comments
Assignees

Comments

@NewJerseyStyle
Copy link
Member

Description:

The closed page is missing a first-level heading (<h1>).

Steps to Reproduce:

  1. Navigate to the closed page.
  2. Inspect the page's heading structure.

Expected Behavior:

A <h1> element should be present.

Actual Behavior:

A <h1> element is missing.

Component/Area: Closed Page

Source: Auto evaluation

Affected Elements: <h1>

@NewJerseyStyle NewJerseyStyle converted this from a draft issue Oct 31, 2024
@yshng yshng self-assigned this Dec 20, 2024
@yshng
Copy link
Collaborator

yshng commented Dec 20, 2024

I was able to reproduce this today running a local instance using Docker
h2-closed

However, the current code in edge-civittechto shows that the <h2> was already replaced by <h1> in #32 by @thomassth on Oct 17 - This issue was opened Oct 30. Perhaps I don't understand something about Docker deployment, or what branch the a11y testing was conducted on? Otherwise it seems this is no longer an issue and can be closed.

@NewJerseyStyle
Copy link
Member Author

No problem. The issue was logged earlier in Google Sheet and later moved to GitHub issues which caused the PR occur before the issue is created 🚀 I guess Tom found the issue in Google Sheet and fixed it in #32 before we sync everything with GitHub (Google Sheet is always give you the fresh a11y issue, GitHub issues is slower)

Thank you @yshng for pointing that out. Let's close this issue since it's been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants