#1070 use pre_execute to reduce # of tasks in partition create taskgroups
#1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pull request accomplishes:
@task.short_circuitoperators topre_execute= reduces # of tasks for partition creates.@task.run_ifwhich would have had the same impact (fewer tasks), but the partition creates are currently PostgresOperators which would have required refactoring them to @task operators.Tested by re-running today's
miovision_pullDAG ✅Issue(s) this solves:
@run_iftask decorator in partition create statements #1070What, in particular, needs to reviewed:
test_dagsaction is failing on deprecatedpull_wysandpull_miovision... Should we delete these DAGs once and for all?What needs to be done by a sysadmin after this PR is merged
E.g.: these tables need to be migrated/created in the production schema.