Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change event_time definition to require correct ordering #301

Conversation

rf-
Copy link
Contributor

@rf- rf- commented Apr 29, 2019

This proposal reflects the consensus of the status change ordering/uniqueness breakout group that it's reasonable to ask providers to construct an accurate and causally-consistent timeline of status
change events. This change will improve API consumers' ability to understand the ordering and timing of events in the status changes API.

See the notes from the first breakout group call for a little bit more context.

Is this a breaking change

  • Yes, breaking
  • No, not breaking
  • I'm not sure

Provider or agency

  • provider
  • agency
  • both

This proposal reflects the consensus of the status change
ordering/uniqueness breakout group that it's reasonable to ask Providers
to construct an accurate and causally-consistent timeline of status
change events.
@rf- rf- requested review from hunterowens, thekaveman and a team as code owners April 29, 2019 19:59
@rf-
Copy link
Contributor Author

rf- commented Apr 29, 2019

An open question here is whether we should also update the start_time and end_time fields on trips to use the same language. I left it out for now since I didn't want to go past the scope of the discussion on the call, but it would probably make sense to be consistent.

@marie-x
Copy link
Collaborator

marie-x commented Apr 29, 2019

This will definitely affect Agency, as the data collected via Agency is made available via Provider.

@marie-x
Copy link
Collaborator

marie-x commented Apr 29, 2019

Seems weird that I can change the check boxes randomly

@toddapetersen
Copy link
Contributor

toddapetersen commented Apr 29, 2019

This will definitely affect Agency, as the data collected via Agency is made available via Provider.

Agree Max... Need to put the brakes on this until we can sync with Agency changes. It is probably time we re-unite the two API's into a single process anyway...they were never meant to be separate.

@marie-x
Copy link
Collaborator

marie-x commented Apr 30, 2019

Agree Max... Need to put the breaks on this until we can sync with Agency changes.

It's not really a code change, though, it's a semantic change if I understand correctly. I'm okay with it as-is. I just wanted to make a note, and update the Agency wording if needed.

I would be curious to hear if the breakout group considered Agency and its quasi-real-time event-reporting requirements. Were there meeting minutes that I missed? [EDIT: Found the meeting minutes]

@hunterowens hunterowens added the State Machine Changes in the vehicle state events and state machine diagram label Apr 30, 2019
@rf-
Copy link
Contributor Author

rf- commented May 10, 2019

We had consensus about this change on the Provider call today—@toddapetersen and @Karcass, do either of you still have any concerns?

@marie-x
Copy link
Collaborator

marie-x commented May 10, 2019

@rf- works for me

@hunterowens hunterowens added this to the 0.3.2 milestone May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State Machine Changes in the vehicle state events and state machine diagram
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants