Add event_type_reason for agency admin access. #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated based on compliance changed approved by LADOT Compliance will exist in a seperate document.
Approved by LADOT. Updated compliance for in-trip telemetry for scooters.
|
👍 |
thekaveman
reviewed
Apr 6, 2019
There was a problem hiding this comment.
I don't think it was clear to me from #278... I feel like the usage of pick_up might be confusing, since our other reasons with this pattern belong to the removed event type.
Is this event supposed to indicate a movement (re-balance/re-park) or a removal/impound?
|
whoops, fixing - that should be a removed event, not unavailable. |
thekaveman
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @margodawes, this adds the event type reasons for agency admin access.
I used the term
agencyrather thanadminfor clarity.