Avoid silent copy of vertices when obtaining vertices count

> `mesh.vertices` returns a copy of _all_ vertices. If you have code like `mesh.vertices.Length`, this will be quite inefficient. It's much better to use `mesh.vertexCount` Source: microsoft/Microsoft.Unity.Analyzers#52
CitiesSkylinesMods · Jun 9, 2020 · fd66d13 · fd66d13
1 parent def7315
commit fd66d13
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/Source/AdditiveShader/Manager/ManagedAsset.cs b/Source/AdditiveShader/Manager/ManagedAsset.cs
@@ -106,7 +106,7 @@ internal ManagedAsset(BuildingInfo asset)
             asset.m_lodHasDifferentShader = false;
             asset.m_lodMissing = true;
             asset.m_material.SetFloat("_InvFade", Info.Fade);
-            asset.m_mesh.colors = GetMeshColors(asset.m_mesh.vertices.Length);
+            asset.m_mesh.colors = GetMeshColors(asset.m_mesh.vertexCount);
 
             CachedRenderDistance = GetRenderDistance(asset.m_generatedInfo.m_size);
             ApplyCachedRenderDistance();
@@ -171,7 +171,7 @@ internal ManagedAsset(BuildingInfoSub asset)
 
             asset.m_lodHasDifferentShader = false;
             asset.m_material.SetFloat("_InvFade", Info.Fade);
-            asset.m_mesh.colors = GetMeshColors(asset.m_mesh.vertices.Length);
+            asset.m_mesh.colors = GetMeshColors(asset.m_mesh.vertexCount);
 
             CachedRenderDistance = GetRenderDistance(asset.m_generatedInfo.m_size);
             ApplyCachedRenderDistance();
@@ -200,7 +200,7 @@ internal ManagedAsset(VehicleInfoSub asset)
             backup_maxRenderDistance = asset.m_maxRenderDistance;
 
             asset.m_material.SetFloat("_InvFade", Info.Fade);
-            asset.m_mesh.colors = GetMeshColors(asset.m_mesh.vertices.Length);
+            asset.m_mesh.colors = GetMeshColors(asset.m_mesh.vertexCount);
 
             CachedRenderDistance = GetRenderDistance(asset.m_generatedInfo.m_size);
             ApplyCachedRenderDistance();