Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for download of ARM binaries for Macs #68

Open
gwidion opened this issue Jun 25, 2024 · 2 comments
Open

Support for download of ARM binaries for Macs #68

gwidion opened this issue Jun 25, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@gwidion
Copy link

gwidion commented Jun 25, 2024

Downloading helm client on Mac will always download amd64 binaries.

    fun getOperatingSystemClassifier() =
        when {
            osName.startsWith("Mac OS X") ->
                "darwin-amd64"

I think this should easily allow downloading arm64 binaries when appropriate.

fun getOperatingSystemClassifier() = 
    when {
        osName.startsWith("Mac OS X") -> 
            when (osArch) {
                "aarch64" -> "darwin-arm64"
                else -> "darwin-amd64"
            }
@imanushin imanushin self-assigned this Jun 25, 2024
@magner669 magner669 added the enhancement New feature or request label Jun 27, 2024
@gwidion
Copy link
Author

gwidion commented Aug 8, 2024

any progress? should I open a MR?

@JamieSlome
Copy link
Member

@gwidion - if you have changes you'd like to suggest, please feel free to open a pull request! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants