Add global option and CLI property to suppress dumping the environment to logs #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Brown <[email protected]>
andysworkshop
force-pushed
the
suppress-dump-env
branch
from
cb3e7bd to
314c582
Compare
|
Would prefer to continue the conversation in the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
helm.suppressEnvironmentLoggingboolean property that will suppress the environment from being dumped to the logs when the logging level is at info or higher. It also works with the command line property -PsuppressEnvironmentLogging=true.Unit tests are included and the asciidoc documentation is updated. I hope nobody minds me introducing functional tests into the main plugin because I found them very useful when I needed to check the gradle output.
Resolves #104