Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GraphQL #69

Closed
rnitame opened this issue Jul 18, 2019 · 3 comments · Fixed by #805
Closed

Add support for GraphQL #69

rnitame opened this issue Jul 18, 2019 · 3 comments · Fixed by #805
Labels
work-in-progress This Issue/PR is currently under development

Comments

@rnitame
Copy link

rnitame commented Jul 18, 2019

Is your feature request related to a problem? Please describe.
I don’t know the details at first glance. Because every request is a POST method to /graphql

ex)

screenshot

Describe the solution you'd like
I want to change POST /graphql to used Query or Mutation name

Describe alternatives you've considered
Add processing to change the string in TransactionAdapter class when endpoint equals /graphql
If there are other good ways, please suggest 🙏

ref: https://graphql.org/learn/serving-over-http/#uris-routes

Do you want to develop this feature yourself?
yes

@cortinico
Copy link
Member

Do you want to develop this feature yourself?
yes

Hey @rnitame
Please let me know if you need some support on this,

I want to change POST /graphql to used Query or Mutation name

Ideally I would add some extra informations but I would keep the full HTTP path.
Like if is a GraphQL request, Chucker could ideally parse the operationName from the body and display it? Also showing an extra icon for GraphQL requests might be valuable

@rnitame
Copy link
Author

rnitame commented Jul 25, 2019

Thank you for idea! @cortinico
My implement plan updated. What do you think?

image

operationName can probably be obtained from requestBody .

https://github.com/ChuckerTeam/chucker/blob/develop/library/src/main/java/com/chuckerteam/chucker/api/internal/data/entity/HttpTransaction.kt#L35

@rnitame
Copy link
Author

rnitame commented Jul 25, 2019

PR is open. I currently development :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress This Issue/PR is currently under development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants