-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional GraphQL Support #116
Comments
++ |
Hi All 👋 , I wanted to check if anybody was working on this feature request? |
This is currently up for grab. Feel free to jump on it 👍 |
Yes, can confirm that the issue is free to be taken. Despite our plans to make some bigger changes, like #259 , etc. we could always update the code you are going to contribute 😄 |
Is your feature request related to a problem? Please describe.
PR #70 (relating to issue #69) adds support for GraphQL by detecting an operation name field in the request. I believe that there are additional nuances to GraphQL we should address before calling our support "complete"
Additional context
PR #70 attempts to parse plain text requests to detect a
operationName
field and if present, the GUI receives the GraphQL icon. It looks like there are several cases where anoperationName
will be absent, but we would want to include the icon.http://myapi/graphql?query={me{name}}
is valid GraphQLDescribe the solution you'd like
GraphQL (like SOAP before it) exposes a single HTTP endpoint, perhaps we could register that with the
ChuckerInterceptor
and avoid introspecting the request looking for an operation name?Also, we parse the request with GSON for all outgoing network calls, in-line with the actual network call. Knowing that a particular URL is a non-GraphQL endpoint would allow us to skip this step. Perhaps we could defer this work to the
HttpTransactionDatabaseRepository
as we will be on a background thread away from the actual network call?Do you want to develop this feature yourself?
I could easily see several user stories to extend the GraphQL support, each of which would add value and could be independently worked by people. I would be happy to work with you on coming up with several new issues, and would also be glad to work on any of them.
The text was updated successfully, but these errors were encountered: