Fix leaking MainActivity #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbuberen
added
bug
MiSikora
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📷 Screenshots
📄 Context
Recently saw a leak reported by LeakCanary and investigated the reason. In some cases Room database initialises with activity context instead of application and it leads to leaks.
📝 Changes
thiswithapplicationContextinBaseActivityto provide properContextobject.Contextis required.🚫 Breaking
Nothing
🛠️ How to test
Just launch sample app and try to play around with the app to see if LeakCanary reports something.
⏱️ Next steps
Probably, we could redo the way repositories initialisation happen. But it is not the top priority now.