Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contradictory option hibernation #2198

Closed
schlusy opened this issue Jun 28, 2024 · 6 comments
Closed

contradictory option hibernation #2198

schlusy opened this issue Jun 28, 2024 · 6 comments
Labels

Comments

@schlusy
Copy link

schlusy commented Jun 28, 2024

Describe the solution you'd like
imho, those 2 options should exclude each other. Both activated seems "wrong" for me

Describe alternatives you've considered
auto-deactivate contradictory option

grafik

@schlusy
Copy link
Author

schlusy commented Jun 28, 2024

if you choose to "Disable Hibernation" after choosing "Set Hibernation as default", it might not do things as users intend to do.

@MyDrift-user
Copy link
Contributor

MyDrift-user commented Jun 28, 2024

If I looked at it correctly they work like following:

  • They do not do the same thing, they both edit a registry element, but not the same.
  • The script attached alwell does not do the same thing.
  • The enable/disable hybernation "overrides" the functionality of the "set as default" tweak.

The two tweaks are not both set for the standard preset, which is good.

But i understand that it looks and feels wrong.

Additional logics outside the executing script to manage that only one of them can be checked at the time would not make sense.

What we could do is making the "set as default" tweak a toggle under preferences.
That would not remove the functionality would stay predefinable, confustion could still be there tho..

Copy link
Contributor

github-actions bot commented Jul 9, 2024

This issue was marked as stale because it has been inactive for 7 days

@github-actions github-actions bot added the Stale label Jul 9, 2024
@Real-MullaC
Copy link
Contributor

Hello, It will be sorted in #2226.

@github-actions github-actions bot removed the Stale label Jul 11, 2024
Copy link
Contributor

This issue was marked as stale because it has been inactive for 7 days

@github-actions github-actions bot added the Stale label Jul 19, 2024
Copy link
Contributor

This issue was closed because it has been inactive for 7 days since it was marked as stale

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants