Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: Add CONTRIBUTING.md and STYLEGUIDE.md to this repo #2115

Open
RobSeder opened this issue Jun 19, 2024 · 2 comments
Open

REQUEST: Add CONTRIBUTING.md and STYLEGUIDE.md to this repo #2115

RobSeder opened this issue Jun 19, 2024 · 2 comments
Labels

Comments

@RobSeder
Copy link

Is your feature request related to a problem? Please describe.

You just made a video about contributing to open source, but not liking the quality or style of pull requests.

Describe the solution you'd like

The GitHub answer to that is to create a CONTRIBUTING.md file that describes how to properly and ideally contribute to your repo. This might include things like "don't make huge changes", "do make a small, specific changes", "Include a cover lever with your PR to describe what you've done", etc.

Also, consider creating a STYLEGUIDE.md file, also in the root of the repo. This will include things like: tabs vs spaces, PascalCase vs camelCase, file naming standards, comment style (e.g. "#" vs "/* */", etc). There is not a formal spec for what is in a repo style guide, so just include the formatting and styling things that you care about.

Describe alternatives you've considered

None. This is for everyone's benefit and it is the industry standard.

Additional context

Adding this communication is a way that you can clearly convey how you would like to see pull requests. Or, if you get a low quality pull request, then you can point the contributor to these files for correction.

@ChrisTitusTech
Copy link
Owner

Thanks for pointing this out Rob, I'll add it to the project!

Copy link
Contributor

This issue was marked as stale because it has been inactive for 7 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants