From 32fc8d07670a8e3b809f2785483e664d32066a53 Mon Sep 17 00:00:00 2001
From: Chris Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
Date: Sun, 26 Apr 2026 21:41:13 -0400
Subject: [PATCH] Fix Release-build analyzer errors

Release builds now run 'dotnet build -c Release' with TreatWarningsAsErrors,
which surfaced existing analyzer findings that Debug builds didn't enforce.

src:
- InMemoryLoggerBuilderExtensions.AddInMemoryLogger: add <exception> XML doc
  for ArgumentNullException (RCS1140)
- InMemoryLoggerProvider.CreateLogger: add <exception> XML doc for
  ArgumentNullException (RCS1140)
- InMemoryLoggerProvider: mark sealed (CA1063, S3881). The class has no
  overridable members and the existing no-op Dispose doesn't justify the
  full Dispose(bool) pattern.

tests:
- InMemoryLogger{,OfT}Tests.Log_when_called_adds_entry_to_LogEntries:
  - Name the 'exception' parameter explicitly (MA0003)
  - Discard unused 'exception' parameter in the formatter delegate
    (RCS1163, S3257)
  - Use indexer on IReadOnlyList instead of First() (CA1826)

Verified locally: Release build 0/0, 52 tests pass on all TFMs.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 .../InMemoryLoggerBuilderExtensions.cs                      | 3 +++
 .../InMemoryLoggerProvider.cs                               | 5 ++++-
 .../InMemoryLoggerOfTTests.cs                               | 6 +++---
 .../InMemoryLoggerTests.cs                                  | 6 +++---
 4 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/src/Wolfgang.Extensions.Logging.InMemoryLogger/InMemoryLoggerBuilderExtensions.cs b/src/Wolfgang.Extensions.Logging.InMemoryLogger/InMemoryLoggerBuilderExtensions.cs
index 45fa458..84a757c 100644
--- a/src/Wolfgang.Extensions.Logging.InMemoryLogger/InMemoryLoggerBuilderExtensions.cs
+++ b/src/Wolfgang.Extensions.Logging.InMemoryLogger/InMemoryLoggerBuilderExtensions.cs
@@ -15,6 +15,9 @@ public static class InMemoryLoggerBuilderExtensions
 	/// <param name="builder">The <see cref="ILoggingBuilder"/> to add the provider to.</param>
 	/// <param name="provider">The <see cref="InMemoryLoggerProvider"/> instance to register.</param>
 	/// <returns>The <see cref="ILoggingBuilder"/> so that additional calls can be chained.</returns>
+	/// <exception cref="ArgumentNullException">
+	/// Thrown when <paramref name="builder"/> or <paramref name="provider"/> is <see langword="null"/>.
+	/// </exception>
 	/// <example>
 	/// <code>
 	/// var provider = new InMemoryLoggerProvider();
diff --git a/src/Wolfgang.Extensions.Logging.InMemoryLogger/InMemoryLoggerProvider.cs b/src/Wolfgang.Extensions.Logging.InMemoryLogger/InMemoryLoggerProvider.cs
index ce52f70..abc25e3 100644
--- a/src/Wolfgang.Extensions.Logging.InMemoryLogger/InMemoryLoggerProvider.cs
+++ b/src/Wolfgang.Extensions.Logging.InMemoryLogger/InMemoryLoggerProvider.cs
@@ -11,7 +11,7 @@ namespace Wolfgang.Extensions.Logging.InMemoryLogger;
 /// An <see cref="ILoggerProvider"/> that creates <see cref="InMemoryLogger"/> instances
 /// and provides access to all log entries across all loggers.
 /// </summary>
-public class InMemoryLoggerProvider : ILoggerProvider
+public sealed class InMemoryLoggerProvider : ILoggerProvider
 {
 	private readonly ConcurrentDictionary<string, InMemoryLogger> _loggers =
 		new ConcurrentDictionary<string, InMemoryLogger>(StringComparer.Ordinal);
@@ -36,6 +36,9 @@ public InMemoryLoggerProvider(LogLevel minLogLevel = LogLevel.Trace)
 	/// </summary>
 	/// <param name="categoryName">The category name for messages produced by the logger.</param>
 	/// <returns>An <see cref="ILogger"/> instance.</returns>
+	/// <exception cref="ArgumentNullException">
+	/// Thrown when <paramref name="categoryName"/> is <see langword="null"/>.
+	/// </exception>
 	public ILogger CreateLogger(string categoryName)
 	{
 		if (categoryName == null)
diff --git a/tests/Wolfgang.Extensions.Logging.InMemoryLogger.Tests.Unit/InMemoryLoggerOfTTests.cs b/tests/Wolfgang.Extensions.Logging.InMemoryLogger.Tests.Unit/InMemoryLoggerOfTTests.cs
index 76cf50c..9d1e968 100644
--- a/tests/Wolfgang.Extensions.Logging.InMemoryLogger.Tests.Unit/InMemoryLoggerOfTTests.cs
+++ b/tests/Wolfgang.Extensions.Logging.InMemoryLogger.Tests.Unit/InMemoryLoggerOfTTests.cs
@@ -30,12 +30,12 @@ public void Log_when_called_adds_entry_to_LogEntries()
             LogLevel.Information,
             new EventId(1, "TestEvent"),
             "Test message",
-            null,
-            (state, exception) => state
+            exception: null,
+            (state, _) => state
         );
 
         Assert.Single(sut.LogEntries);
-        var logEntry = sut.LogEntries.First();
+        var logEntry = sut.LogEntries[0];
         Assert.Equal(LogLevel.Information, logEntry.LogLevel);
         Assert.Equal(1, logEntry.EventId.Id);
         Assert.Equal("TestEvent", logEntry.EventId.Name);
diff --git a/tests/Wolfgang.Extensions.Logging.InMemoryLogger.Tests.Unit/InMemoryLoggerTests.cs b/tests/Wolfgang.Extensions.Logging.InMemoryLogger.Tests.Unit/InMemoryLoggerTests.cs
index b3efea2..e1e0f72 100644
--- a/tests/Wolfgang.Extensions.Logging.InMemoryLogger.Tests.Unit/InMemoryLoggerTests.cs
+++ b/tests/Wolfgang.Extensions.Logging.InMemoryLogger.Tests.Unit/InMemoryLoggerTests.cs
@@ -78,12 +78,12 @@ public void Log_when_called_adds_entry_to_LogEntries()
             LogLevel.Information,
             new EventId(1, "TestEvent"),
             "Test message",
-            null,
-            (state, exception) => state
+            exception: null,
+            (state, _) => state
         );
 
         Assert.Single(sut.LogEntries);
-        var logEntry = sut.LogEntries.First();
+        var logEntry = sut.LogEntries[0];
         Assert.Equal(LogLevel.Information, logEntry.LogLevel);
         Assert.Equal("TestCategory", logEntry.Category);
         Assert.Equal(1, logEntry.EventId.Id);