From bd6ef1426eccf40d150ce786c9f1d413c8c777fa Mon Sep 17 00:00:00 2001
From: Chris Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
Date: Fri, 27 Mar 2026 09:14:34 -0400
Subject: [PATCH] Remove coverlet.runsettings and netstandard coverage
 exclusion

With netcoreapp3.1 removed from source, the netcoreapp3.1 tests
now run against the netstandard2.0 assembly, providing direct
coverage of those code paths. The runsettings file and the
ExcludeFromCodeCoverage property are no longer needed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 .github/workflows/pr.yaml                     |  3 ---
 .github/workflows/release.yaml                |  2 --
 coverlet.runsettings                          | 25 -------------------
 .../Wolfgang.Etl.Abstractions.csproj          |  6 -----
 4 files changed, 36 deletions(-)
 delete mode 100644 coverlet.runsettings

diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml
index 30d1fc9..6f6b3d2 100644
--- a/.github/workflows/pr.yaml
+++ b/.github/workflows/pr.yaml
@@ -292,7 +292,6 @@ jobs:
                   --configuration Release \
                   --framework "$fw" \
                   --collect:"XPlat Code Coverage" \
-                  --settings coverlet.runsettings \
                   --results-directory "./TestResults" \
                   --logger "console;verbosity=minimal" || exit 1
               else
@@ -518,7 +517,6 @@ jobs:
                   --configuration Release `
                   --framework $fw `
                   --collect:"XPlat Code Coverage" `
-                  --settings coverlet.runsettings `
                   --results-directory "./TestResults" `
                   --logger "console;verbosity=normal"
               } else {
@@ -824,7 +822,6 @@ jobs:
                 --configuration Release \
                 --framework "$fw" \
                 --collect:"XPlat Code Coverage" \
-                --settings coverlet.runsettings \
                 --results-directory "./TestResults" \
                 --logger "console;verbosity=normal" || exit 1
             done <<< "$frameworks"
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
index 5b2ab18..d1f78b7 100644
--- a/.github/workflows/release.yaml
+++ b/.github/workflows/release.yaml
@@ -161,7 +161,6 @@ jobs:
                   --no-build `
                   --no-restore `
                   --collect:"XPlat Code Coverage" `
-                  --settings coverlet.runsettings `
                   --results-directory "./TestResults" `
                   --logger "console;verbosity=minimal"
 
@@ -183,7 +182,6 @@ jobs:
                   --no-build `
                   --no-restore `
                   --collect:"XPlat Code Coverage" `
-                  --settings coverlet.runsettings `
                   --results-directory "./TestResults" `
                   --logger "console;verbosity=minimal"
               } else {
diff --git a/coverlet.runsettings b/coverlet.runsettings
deleted file mode 100644
index f58bb8c..0000000
--- a/coverlet.runsettings
+++ /dev/null
@@ -1,25 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<!--
-  Coverlet run settings for Wolfgang.Etl.Abstractions.
-
-  netstandard2.0 and netstandard2.1 assemblies are excluded from coverage.
-  No test project targets these TFMs, so every branch in their builds would
-  show as uncovered and skew the aggregate numbers.  The #else fallback paths
-  they contain exist purely for TFM compatibility and are exercised indirectly
-  by the older .NET Framework and netcoreapp3.1 test runs.
--->
-<RunSettings>
-  <DataCollectionRunSettings>
-    <DataCollectors>
-      <DataCollector friendlyName="XPlat Code Coverage">
-        <Configuration>
-          <!-- Exclude the netstandard TFM builds by their output-path fragment.
-               Coverlet resolves source files relative to the pdb; the obj path
-               always contains the TFM name as a directory segment. -->
-          <ExcludeByFile>**/bin/**/netstandard*/**/*.cs;**/obj/**/netstandard*/**/*.cs</ExcludeByFile>
-          <ExcludeByAttribute>ExcludeFromCodeCoverageAttribute</ExcludeByAttribute>
-        </Configuration>
-      </DataCollector>
-    </DataCollectors>
-  </DataCollectionRunSettings>
-</RunSettings>
diff --git a/src/Wolfgang.Etl.Abstractions/Wolfgang.Etl.Abstractions.csproj b/src/Wolfgang.Etl.Abstractions/Wolfgang.Etl.Abstractions.csproj
index 4096d4f..581bdbb 100644
--- a/src/Wolfgang.Etl.Abstractions/Wolfgang.Etl.Abstractions.csproj
+++ b/src/Wolfgang.Etl.Abstractions/Wolfgang.Etl.Abstractions.csproj
@@ -41,12 +41,6 @@
     </None>
   </ItemGroup>
 
-  <!-- No test project targets netstandard TFMs; exclude them from coverage so they don't
-       drag the aggregate below the gate. ExcludeFromCodeCoverage is the MSBuild property
-       read by dotCover (JetBrains), and the coverlet.runsettings ExcludeByFile handles CI. -->
-  <PropertyGroup Condition="$(TargetFramework.StartsWith('netstandard'))">
-    <ExcludeFromCodeCoverage>true</ExcludeFromCodeCoverage>
-  </PropertyGroup>
 
   <!--
     Microsoft.Bcl.AsyncInterfaces: the runtime assembly is built into net8+, so pre-net8 TFMs