[fix] App randomly crash after entering Movie Detail

[ChoiysApple]

Cause

App randomly crashed because of error while decoding MovieDetail model

Solution

• Need to fix Movie Detail model
• [refactor] Fix force decoding API response, Separate API response model and Model for View #43 (Continue Work on this issue later)

[ChoiysApple]

App crash not happened after #19 issue is solved.
Code improvement will continue on issue #43

[ChoiysApple]

Issue found for movieId: 401068

{
  "adult": false,
  "backdrop_path": null,
  "belongs_to_collection": null,
  "budget": 0,
  "genres": [
    {
      "id": 35,
      "name": "Comedy"
    }
  ],
  "homepage": "",
  "id": 401068,
  "imdb_id": "tt1243457",
  "original_language": "en",
  "original_title": "Dave Attell - HBO Comedy Half-Hour",
  "overview": "Dave Attell brings us more of his good old stand-up jokes about cow sex and trash trucks in this half-hour comedy special.",
  "popularity": 1.164,
  "poster_path": null,
  "production_companies": [
    {
      "id": 3268,
      "logo_path": "/tuomPhY2UtuPTqqFnKMVHvSb724.png",
      "name": "HBO",
      "origin_country": "US"
    },
    {
      "id": 8803,
      "logo_path": null,
      "name": "Production Partners",
      "origin_country": ""
    }
  ],
  "production_countries": [
    {
      "iso_3166_1": "US",
      "name": "United States of America"
    }
  ],
  "release_date": "1996-08-16",
  "revenue": 0,
  "runtime": 27,
  "spoken_languages": [
    {
      "english_name": "English",
      "iso_639_1": "en",
      "name": "English"
    }
  ],
  "status": "Released",
  "tagline": "",
  "title": "Dave Attell - HBO Comedy Half-Hour",
  "video": false,
  "vote_average": 1,
  "vote_count": 1
}

[ChoiysApple]

Crash cases

Id	Null items
401068	backdrop_path, belongs_to_collection
438836	backdrop_path, belongs_to_collection
377532	imdb_id

[ChoiysApple]

Cause

MovieData Model is made for decoding response of Movie Detail request. But It cannot handle if there's null response.

Solution

1. Change all of MovieData's property into Optional (Cannot find proper reference for MovieDB)

// MARK: - MovieDetail
struct MovieDetail: Codable {
    let adult: Bool?
    let backdropPath: String?
    let belongsToCollection: BelongsToCollection?
    let budget: Int?
...

2. Change data setting method from DetailViewController to handle Optional values and change some UI when there's empty data (Hiding backdropImage)

// Binding Helper
private func applyMovieDetailData(data: MovieDetail) {
    
    if let backdropPath = data.backdropPath {
        self.backDropImage.setImage(path: APIService.configureUrlString(imagePath: data.backdropPath))
    } else {
       // Make some space for backButton when there's no Backdrop image
        self.backDropImage.isHidden = true
        self.backDropImage.snp.remakeConstraints { make in
            make.top.left.right.equalToSuperview()
            make.width.equalToSuperview()
            make.bottom.equalTo(backButton.snp.bottom)
        }
    }
    
    self.titleLabel.text = data.title
    self.taglineLabel.text = data.tagline
    
    if let runtime = data.runtime {
        self.runtimeIconLabel.label.text = "\(runtime) min"
    } else {
        self.runtimeIconLabel.isHidden = true
    }
    
    if let voteAverage = data.voteAverage {
        self.ratingIconLabel.label.text = String(voteAverage)
    } else {
        self.ratingIconLabel.isHidden = true
    }
    
    self.overview.contentLabel.text = data.overview
    self.dateGenre.leftDescription.contentLabel.text = data.releaseDate?.replacingOccurrences(of: "-", with: ".")
    
    let genres = data.genres?.compactMap { $0.name }.joined(separator: ", ")
    self.dateGenre.rightDescription.contentLabel.text = genres
}

This issue is fixed, but need more improvement with refactoring

• [refactor] Fix force decoding API response, Separate API response model and Model for View #43