From c8a6d8cc0904a6f0afbfb8d660fa7c4be74f0916 Mon Sep 17 00:00:00 2001 From: tobias-tengler <45513122+tobias-tengler@users.noreply.github.com> Date: Mon, 18 May 2026 14:40:46 +0200 Subject: [PATCH] Remove locations for Fusion errors during execution --- .../Execution/Results/ValueCompletion.cs | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Results/ValueCompletion.cs b/src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Results/ValueCompletion.cs index 5fcac27ae68..f9cfb844cb3 100644 --- a/src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Results/ValueCompletion.cs +++ b/src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Results/ValueCompletion.cs @@ -217,15 +217,9 @@ public void FinalizePocketedErrors(CompositeResultElement resultData) if (parentResult.ValueKind is JsonValueKind.Undefined) { - var parentSelection = parentResult.Selection; var promotedError = ErrorBuilder.FromError(error) .SetPath(parentPath); - if (parentSelection is not null) - { - promotedError = promotedError.AddLocation(parentSelection.SyntaxNodes[0].Node); - } - _store.AddError(_errorHandler.Handle(promotedError.Build())); parentResult.SetNullValue(); _store.RemovePocketedErrorsInSubtree(parentPath); @@ -431,7 +425,6 @@ private bool ApplyFieldError( { var errorWithPath = ErrorBuilder.FromError(error) .SetPath(path) - .AddLocation(selection.SyntaxNodes[0].Node) .Build(); errorWithPath = _errorHandler.Handle(errorWithPath); @@ -498,7 +491,6 @@ private bool TryCompleteValue( var path = target.CompactPath.ToPath(target.Operation); error = ErrorBuilder.FromError(errorFromPath) .SetPath(path) - .AddLocation(selection.SyntaxNodes[0].Node) .Build(); } else @@ -508,7 +500,6 @@ private bool TryCompleteValue( .SetMessage("Cannot return null for non-nullable field.") .SetCode(ErrorCodes.Execution.NonNullViolation) .SetPath(path) - .AddLocation(selection.SyntaxNodes[0].Node) .Build(); } @@ -545,7 +536,6 @@ private bool TryCompleteValue( { var errorWithPath = ErrorBuilder.FromError(errorFromPath) .SetPath(target.Path) - .AddLocation(selection.SyntaxNodes[0].Node) .Build(); errorWithPath = _errorHandler.Handle(errorWithPath); @@ -636,7 +626,6 @@ private bool TryCompleteList( { var errorWithPath = ErrorBuilder.FromError(error) .SetPath(target.CompactPath.ToPath(target.Operation, i)) - .AddLocation(selection.SyntaxNodes[0].Node) .Build(); errorWithPath = _errorHandler.Handle(errorWithPath);