diff --git a/src/Directory.Packages.props b/src/Directory.Packages.props index a42a7ca472f..3ae38c70ca1 100644 --- a/src/Directory.Packages.props +++ b/src/Directory.Packages.props @@ -39,7 +39,7 @@ - + diff --git a/src/HotChocolate/Diagnostics/src/Diagnostics/ActivityEnricher.cs b/src/HotChocolate/Diagnostics/src/Diagnostics/ActivityEnricher.cs index 4901ab1a26a..07607fd0fe7 100644 --- a/src/HotChocolate/Diagnostics/src/Diagnostics/ActivityEnricher.cs +++ b/src/HotChocolate/Diagnostics/src/Diagnostics/ActivityEnricher.cs @@ -12,7 +12,6 @@ using HotChocolate.Language.Utilities; using HotChocolate.Resolvers; using HotChocolate.Types; -using OpenTelemetry.Trace; using static HotChocolate.Diagnostics.SemanticConventions; using static HotChocolate.WellKnownContextData; @@ -589,7 +588,7 @@ protected virtual void EnrichError(IError error, Activity activity) { if (error.Exception is { } exception) { - activity.RecordException(exception); + activity.AddException(exception); } var tags = new ActivityTagsCollection diff --git a/src/HotChocolate/Diagnostics/src/Diagnostics/Listeners/ActivityExecutionDiagnosticListener.cs b/src/HotChocolate/Diagnostics/src/Diagnostics/Listeners/ActivityExecutionDiagnosticListener.cs index 4eefab1b301..3a2c175e26c 100644 --- a/src/HotChocolate/Diagnostics/src/Diagnostics/Listeners/ActivityExecutionDiagnosticListener.cs +++ b/src/HotChocolate/Diagnostics/src/Diagnostics/Listeners/ActivityExecutionDiagnosticListener.cs @@ -5,7 +5,6 @@ using HotChocolate.Execution.Instrumentation; using HotChocolate.Execution.Processing; using HotChocolate.Resolvers; -using OpenTelemetry.Trace; using static HotChocolate.Diagnostics.ContextKeys; using static HotChocolate.Diagnostics.HotChocolateActivitySource; @@ -121,7 +120,6 @@ public override void SyntaxError(IRequestContext context, IError error) var activity = (Activity)value; _enricher.EnrichSyntaxError(context, activity, error); - activity.SetStatus(Status.Error); activity.SetStatus(ActivityStatusCode.Error); } } @@ -158,7 +156,6 @@ public override void ValidationErrors(IRequestContext context, IReadOnlyList err _enricher.EnrichParserErrors(context, error, activity); } - activity.SetStatus(Status.Error); activity.SetStatus(ActivityStatusCode.Error); } } diff --git a/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/CoerceVariablesScope.cs b/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/CoerceVariablesScope.cs index f594cccd8a4..e461464df3e 100644 --- a/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/CoerceVariablesScope.cs +++ b/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/CoerceVariablesScope.cs @@ -1,6 +1,5 @@ using System.Diagnostics; using HotChocolate.Execution; -using OpenTelemetry.Trace; namespace HotChocolate.Diagnostics.Scopes; @@ -21,7 +20,6 @@ protected override void SetStatus() { if (Context.Variables is not null) { - Activity.SetStatus(Status.Ok); Activity.SetStatus(ActivityStatusCode.Ok); } } diff --git a/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/CompileOperationScope.cs b/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/CompileOperationScope.cs index 00e00af39a9..d685017180d 100644 --- a/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/CompileOperationScope.cs +++ b/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/CompileOperationScope.cs @@ -1,6 +1,5 @@ using System.Diagnostics; using HotChocolate.Execution; -using OpenTelemetry.Trace; namespace HotChocolate.Diagnostics.Scopes; @@ -21,7 +20,6 @@ protected override void SetStatus() { if (Context.Operation is not null) { - Activity.SetStatus(Status.Ok); Activity.SetStatus(ActivityStatusCode.Ok); } } diff --git a/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ExecuteOperationScope.cs b/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ExecuteOperationScope.cs index fae426b9e88..e76ad363c06 100644 --- a/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ExecuteOperationScope.cs +++ b/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ExecuteOperationScope.cs @@ -1,6 +1,5 @@ using System.Diagnostics; using HotChocolate.Execution; -using OpenTelemetry.Trace; namespace HotChocolate.Diagnostics.Scopes; @@ -21,12 +20,10 @@ protected override void SetStatus() { if (Context.Result is null or IOperationResult { Errors: [_, ..] }) { - Activity.SetStatus(Status.Error); Activity.SetStatus(ActivityStatusCode.Error); } else { - Activity.SetStatus(Status.Ok); Activity.SetStatus(ActivityStatusCode.Ok); } } diff --git a/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ExecuteRequestScope.cs b/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ExecuteRequestScope.cs index 37fe4ef2d4d..bb30c36d2f0 100644 --- a/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ExecuteRequestScope.cs +++ b/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ExecuteRequestScope.cs @@ -1,6 +1,5 @@ using System.Diagnostics; using HotChocolate.Execution; -using OpenTelemetry.Trace; namespace HotChocolate.Diagnostics.Scopes; @@ -21,7 +20,6 @@ protected override void SetStatus() { if (Context.Result is null or IOperationResult { Errors: [_, ..] }) { - Activity.SetStatus(Status.Error); Activity.SetStatus(ActivityStatusCode.Error); } } diff --git a/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ParseDocumentScope.cs b/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ParseDocumentScope.cs index 75c63ed3e1c..ad273c39461 100644 --- a/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ParseDocumentScope.cs +++ b/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ParseDocumentScope.cs @@ -1,6 +1,5 @@ using System.Diagnostics; using HotChocolate.Execution; -using OpenTelemetry.Trace; namespace HotChocolate.Diagnostics.Scopes; @@ -21,7 +20,6 @@ protected override void SetStatus() { if (Context.Document is not null) { - Activity.SetStatus(Status.Ok); Activity.SetStatus(ActivityStatusCode.Ok); } } diff --git a/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ValidateDocumentScope.cs b/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ValidateDocumentScope.cs index ed4cb7cef6b..767e0c8a783 100644 --- a/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ValidateDocumentScope.cs +++ b/src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ValidateDocumentScope.cs @@ -1,6 +1,5 @@ using System.Diagnostics; using HotChocolate.Execution; -using OpenTelemetry.Trace; namespace HotChocolate.Diagnostics.Scopes; @@ -21,7 +20,6 @@ protected override void SetStatus() { if (Context.IsValidDocument) { - Activity.SetStatus(Status.Ok); Activity.SetStatus(ActivityStatusCode.Ok); } } diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Allow_document_to_be_captured.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Allow_document_to_be_captured.snap index b2ae1cfdaa4..c676dd2b92f 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Allow_document_to_be_captured.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Allow_document_to_be_captured.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteRequest", @@ -41,12 +41,7 @@ "OperationName": "ParseDocument", "DisplayName": "Parse Document", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -61,10 +56,6 @@ { "Key": "graphql.document.hash", "Value": "6af18618ae20c266f6ffc352b78cb69b" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -73,24 +64,14 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "ExecuteOperation", "DisplayName": "Execute Operation SayHelloOperation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [], "activities": [ { @@ -125,10 +106,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "SimpleQuery" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Cause_a_resolver_error_that_deletes_the_whole_result.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Cause_a_resolver_error_that_deletes_the_whole_result.snap index 6796e441e76..218892cfe83 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Cause_a_resolver_error_that_deletes_the_whole_result.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Cause_a_resolver_error_that_deletes_the_whole_result.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteRequest", @@ -24,10 +24,6 @@ { "Key": "graphql.document.body", "Value": "query SayHelloOperation {\n causeFatalError\n}" - }, - { - "Key": "otel.status_code", - "Value": "ERROR" } ], "event": [ @@ -45,12 +41,7 @@ "OperationName": "ParseDocument", "DisplayName": "Parse Document", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -65,10 +56,6 @@ { "Key": "graphql.document.hash", "Value": "851fb754d9ba6b5cc5a55ebcbea2621d" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -77,24 +64,14 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "ExecuteOperation", "DisplayName": "Execute Operation SayHelloOperation", "Status": "Error", - "tags": [ - { - "Key": "otel.status_code", - "Value": "ERROR" - } - ], + "tags": [], "event": [], "activities": [ { @@ -129,10 +106,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "SimpleQuery" - }, - { - "Key": "otel.status_code", - "Value": "ERROR" } ], "event": [ diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Cause_a_resolver_error_that_deletes_the_whole_result_deep.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Cause_a_resolver_error_that_deletes_the_whole_result_deep.snap index df987de347c..bcb5ca9d8af 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Cause_a_resolver_error_that_deletes_the_whole_result_deep.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Cause_a_resolver_error_that_deletes_the_whole_result_deep.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteRequest", @@ -16,10 +16,6 @@ { "Key": "graphql.document.body", "Value": "query SayHelloOperation {\n deep {\n deeper {\n deeps {\n deeper {\n causeFatalError\n }\n }\n }\n }\n}" - }, - { - "Key": "otel.status_code", - "Value": "ERROR" } ], "event": [], @@ -28,12 +24,7 @@ "OperationName": "ParseDocument", "DisplayName": "Parse Document", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -41,10 +32,6 @@ "DisplayName": "Validate Document", "Status": "Error", "tags": [ - { - "Key": "otel.status_code", - "Value": "ERROR" - }, { "Key": "graphql.document.id", "Value": "803df9346db185e9dc0b22dd3909aa70" diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Create_operation_display_name_with_1_field.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Create_operation_display_name_with_1_field.snap index 771be359ae1..de020111ca2 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Create_operation_display_name_with_1_field.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Create_operation_display_name_with_1_field.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteRequest", @@ -33,12 +33,7 @@ "OperationName": "ParseDocument", "DisplayName": "Parse Document", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -53,10 +48,6 @@ { "Key": "graphql.document.hash", "Value": "452ea802c4d1bf2a81a7411b0b361d9f" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -65,24 +56,14 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "ExecuteOperation", "DisplayName": "Execute Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [], "activities": [ { @@ -117,10 +98,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "SimpleQuery" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Create_operation_display_name_with_1_field_and_op.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Create_operation_display_name_with_1_field_and_op.snap index 2700e91cddf..b25ec9938e8 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Create_operation_display_name_with_1_field_and_op.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Create_operation_display_name_with_1_field_and_op.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteRequest", @@ -37,12 +37,7 @@ "OperationName": "ParseDocument", "DisplayName": "Parse Document", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -57,10 +52,6 @@ { "Key": "graphql.document.hash", "Value": "cee0e2939ece72d650cb0331f4be4669" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -69,24 +60,14 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "ExecuteOperation", "DisplayName": "Execute Operation GetA", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [], "activities": [ { @@ -121,10 +102,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "SimpleQuery" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Create_operation_display_name_with_3_field.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Create_operation_display_name_with_3_field.snap index 783652f24f0..cd5e3dd0f08 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Create_operation_display_name_with_3_field.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Create_operation_display_name_with_3_field.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteRequest", @@ -33,12 +33,7 @@ "OperationName": "ParseDocument", "DisplayName": "Parse Document", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -53,10 +48,6 @@ { "Key": "graphql.document.hash", "Value": "2e55fbe10a9e3ddf26935a8f8d15ec89" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -65,24 +56,14 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "ExecuteOperation", "DisplayName": "Execute Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [], "activities": [ { @@ -117,10 +98,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "SimpleQuery" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -157,10 +134,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "SimpleQuery" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -197,10 +170,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "SimpleQuery" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Create_operation_display_name_with_4_field.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Create_operation_display_name_with_4_field.snap index 0e8e0a920fb..a7c45ac5d3b 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Create_operation_display_name_with_4_field.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Create_operation_display_name_with_4_field.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteRequest", @@ -33,12 +33,7 @@ "OperationName": "ParseDocument", "DisplayName": "Parse Document", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -53,10 +48,6 @@ { "Key": "graphql.document.hash", "Value": "a5f924bb2f5f8651014e92e1cc2428c7" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -65,24 +56,14 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "ExecuteOperation", "DisplayName": "Execute Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [], "activities": [ { @@ -117,10 +98,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "SimpleQuery" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -157,10 +134,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "SimpleQuery" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -197,10 +170,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "SimpleQuery" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -237,10 +206,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "SimpleQuery" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Ensure_operation_name_is_used_as_request_name.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Ensure_operation_name_is_used_as_request_name.snap index b8ab25a95f0..e78943f6aa3 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Ensure_operation_name_is_used_as_request_name.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Ensure_operation_name_is_used_as_request_name.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteRequest", @@ -37,12 +37,7 @@ "OperationName": "ParseDocument", "DisplayName": "Parse Document", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -57,10 +52,6 @@ { "Key": "graphql.document.hash", "Value": "6af18618ae20c266f6ffc352b78cb69b" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -69,24 +60,14 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "ExecuteOperation", "DisplayName": "Execute Operation SayHelloOperation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [], "activities": [ { @@ -121,10 +102,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "SimpleQuery" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Ensure_that_the_validation_activity_has_an_error_status.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Ensure_that_the_validation_activity_has_an_error_status.snap index c13dbaa8b92..778c7bf668d 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Ensure_that_the_validation_activity_has_an_error_status.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Ensure_that_the_validation_activity_has_an_error_status.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteRequest", @@ -16,10 +16,6 @@ { "Key": "graphql.document.body", "Value": "query SayHelloOperation {\n sayHello_\n}" - }, - { - "Key": "otel.status_code", - "Value": "ERROR" } ], "event": [], @@ -28,12 +24,7 @@ "OperationName": "ParseDocument", "DisplayName": "Parse Document", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -41,10 +32,6 @@ "DisplayName": "Validate Document", "Status": "Error", "tags": [ - { - "Key": "otel.status_code", - "Value": "ERROR" - }, { "Key": "graphql.document.id", "Value": "bb1d246465341a97bdc727d6cd8ead5c" diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Track_data_loader_events.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Track_data_loader_events.snap index 63621e43fdd..81846ea2fb2 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Track_data_loader_events.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Track_data_loader_events.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ValidateDocument", @@ -12,10 +12,6 @@ { "Key": "graphql.document.hash", "Value": "9b20745108c8de5afccc35cd56ead9fc" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -24,12 +20,7 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -64,10 +55,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "SimpleQuery" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Track_data_loader_events_with_keys.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Track_data_loader_events_with_keys.snap index 63621e43fdd..81846ea2fb2 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Track_data_loader_events_with_keys.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Track_data_loader_events_with_keys.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ValidateDocument", @@ -12,10 +12,6 @@ { "Key": "graphql.document.hash", "Value": "9b20745108c8de5afccc35cd56ead9fc" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -24,12 +20,7 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -64,10 +55,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "SimpleQuery" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Track_events_of_a_simple_query_default.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Track_events_of_a_simple_query_default.snap index 31c920d0d93..c52c270e5c5 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Track_events_of_a_simple_query_default.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Track_events_of_a_simple_query_default.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ValidateDocument", @@ -12,10 +12,6 @@ { "Key": "graphql.document.hash", "Value": "f7e9989fbb67af7fa747a9983313c9e5" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -24,12 +20,7 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -64,10 +55,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "SimpleQuery" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Track_events_of_a_simple_query_detailed.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Track_events_of_a_simple_query_detailed.snap index 274c05d4964..52985b409d8 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Track_events_of_a_simple_query_detailed.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/QueryInstrumentationTests.Track_events_of_a_simple_query_detailed.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteRequest", @@ -33,12 +33,7 @@ "OperationName": "ParseDocument", "DisplayName": "Parse Document", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -53,10 +48,6 @@ { "Key": "graphql.document.hash", "Value": "f7e9989fbb67af7fa747a9983313c9e5" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -65,24 +56,14 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "ExecuteOperation", "DisplayName": "Execute Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [], "activities": [ { @@ -117,10 +98,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "SimpleQuery" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Get_SingleRequest_GetHeroName.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Get_SingleRequest_GetHeroName.snap index c1a100b164a..26270eb71d2 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Get_SingleRequest_GetHeroName.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Get_SingleRequest_GetHeroName.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteHttpRequest", @@ -24,12 +24,7 @@ "OperationName": "ParseHttpRequest", "DisplayName": "Parse HTTP Request", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -65,10 +60,6 @@ { "Key": "graphql.document.id", "Value": "530cb46cabc38757c74c05cc7a96b636" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -89,24 +80,14 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "ExecuteOperation", "DisplayName": "Execute Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [], "activities": [ { @@ -141,10 +122,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "Query" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_SingleRequest_GetHeroName.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_SingleRequest_GetHeroName.snap index f73f2b8de05..d4a110a3869 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_SingleRequest_GetHeroName.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_SingleRequest_GetHeroName.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteHttpRequest", @@ -28,12 +28,7 @@ "OperationName": "ParseHttpRequest", "DisplayName": "Parse HTTP Request", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -69,10 +64,6 @@ { "Key": "graphql.document.id", "Value": "a570a6bff748b5916eadf153261d9c6d" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -93,24 +84,14 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "ExecuteOperation", "DisplayName": "Execute Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [], "activities": [ { @@ -145,10 +126,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "Query" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_SingleRequest_GetHeroName_Default.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_SingleRequest_GetHeroName_Default.snap index afe49f4b835..69421dbd98c 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_SingleRequest_GetHeroName_Default.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_SingleRequest_GetHeroName_Default.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteHttpRequest", @@ -45,12 +45,7 @@ "OperationName": "ParseHttpRequest", "DisplayName": "Parse HTTP Request", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -61,10 +56,6 @@ { "Key": "graphql.document.id", "Value": "a570a6bff748b5916eadf153261d9c6d" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -73,12 +64,7 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -113,10 +99,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "Query" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_add_query_to_http_activity.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_add_query_to_http_activity.snap index 3360dceec8a..30876c048e5 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_add_query_to_http_activity.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_add_query_to_http_activity.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteHttpRequest", @@ -32,12 +32,7 @@ "OperationName": "ParseHttpRequest", "DisplayName": "Parse HTTP Request", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -73,10 +68,6 @@ { "Key": "graphql.document.id", "Value": "1d4bca4d0dff630390ddf48e9085589d" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -97,36 +88,21 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "CoerceVariables", "DisplayName": "Coerce Variable", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "ExecuteOperation", "DisplayName": "Execute Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [], "activities": [ { @@ -161,10 +137,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "Query" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_add_variables_to_http_activity.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_add_variables_to_http_activity.snap index 3360dceec8a..30876c048e5 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_add_variables_to_http_activity.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_add_variables_to_http_activity.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteHttpRequest", @@ -32,12 +32,7 @@ "OperationName": "ParseHttpRequest", "DisplayName": "Parse HTTP Request", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -73,10 +68,6 @@ { "Key": "graphql.document.id", "Value": "1d4bca4d0dff630390ddf48e9085589d" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -97,36 +88,21 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "CoerceVariables", "DisplayName": "Coerce Variable", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "ExecuteOperation", "DisplayName": "Execute Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [], "activities": [ { @@ -161,10 +137,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "Query" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_capture_deferred_response.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_capture_deferred_response.snap index e5410250f9e..3c72600cdfc 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_capture_deferred_response.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_capture_deferred_response.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteHttpRequest", @@ -28,12 +28,7 @@ "OperationName": "ParseHttpRequest", "DisplayName": "Parse HTTP Request", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -69,10 +64,6 @@ { "Key": "graphql.document.id", "Value": "c563b5e7a3e68a1f25847ac7ab07017c" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -93,24 +84,14 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "ExecuteOperation", "DisplayName": "Execute Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [], "activities": [ { @@ -145,10 +126,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "Query" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [], @@ -185,10 +162,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "Droid" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_ensure_list_path_is_correctly_built.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_ensure_list_path_is_correctly_built.snap index 37b1b8661ea..82cc829d433 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_ensure_list_path_is_correctly_built.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_ensure_list_path_is_correctly_built.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteHttpRequest", @@ -28,12 +28,7 @@ "OperationName": "ParseHttpRequest", "DisplayName": "Parse HTTP Request", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -69,10 +64,6 @@ { "Key": "graphql.document.id", "Value": "c0513b4b6f0cf7430f64de4aa3dcd7c6" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -93,24 +84,14 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "ExecuteOperation", "DisplayName": "Execute Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [], "activities": [ { @@ -145,10 +126,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "Query" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -185,10 +162,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "Droid" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -225,10 +198,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "Human" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -265,10 +234,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "Human" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -305,10 +270,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "Human" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_parser_error.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_parser_error.snap index e33490a9a8c..e2ed5e6944b 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_parser_error.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_parser_error.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteHttpRequest", @@ -16,12 +16,7 @@ "OperationName": "ParseHttpRequest", "DisplayName": "Parse HTTP Request", "Status": "Error", - "tags": [ - { - "Key": "otel.status_code", - "Value": "ERROR" - } - ], + "tags": [], "event": [ { "Name": "exception", diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_variables_are_not_automatically_added_to_activities.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_variables_are_not_automatically_added_to_activities.snap index e375ac2bace..2eecff3155c 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_variables_are_not_automatically_added_to_activities.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_variables_are_not_automatically_added_to_activities.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteHttpRequest", @@ -28,12 +28,7 @@ "OperationName": "ParseHttpRequest", "DisplayName": "Parse HTTP Request", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -69,10 +64,6 @@ { "Key": "graphql.document.id", "Value": "1d4bca4d0dff630390ddf48e9085589d" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -93,36 +84,21 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "CoerceVariables", "DisplayName": "Coerce Variable", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "ExecuteOperation", "DisplayName": "Execute Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [], "activities": [ { @@ -157,10 +133,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "Query" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_with_extensions_map.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_with_extensions_map.snap index 708120e7fda..91b6076552f 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_with_extensions_map.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Http_Post_with_extensions_map.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteHttpRequest", @@ -32,12 +32,7 @@ "OperationName": "ParseHttpRequest", "DisplayName": "Parse HTTP Request", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -73,10 +68,6 @@ { "Key": "graphql.document.id", "Value": "1d4bca4d0dff630390ddf48e9085589d" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] @@ -97,36 +88,21 @@ "OperationName": "CompileOperation", "DisplayName": "Compile Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "CoerceVariables", "DisplayName": "Coerce Variable", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { "OperationName": "ExecuteOperation", "DisplayName": "Execute Operation", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [], "activities": [ { @@ -161,10 +137,6 @@ { "Key": "graphql.selection.field.declaringType", "Value": "Query" - }, - { - "Key": "otel.status_code", - "Value": "OK" } ], "event": [] diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Parsing_error_when_rename_root_is_activated.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Parsing_error_when_rename_root_is_activated.snap index b0834861a59..9f86db9b22c 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Parsing_error_when_rename_root_is_activated.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Parsing_error_when_rename_root_is_activated.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteHttpRequest", @@ -16,12 +16,7 @@ "OperationName": "ParseHttpRequest", "DisplayName": "Parse HTTP Request", "Status": "Error", - "tags": [ - { - "Key": "otel.status_code", - "Value": "ERROR" - } - ], + "tags": [], "event": [ { "Name": "exception", diff --git a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Validation_error_when_rename_root_is_activated.snap b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Validation_error_when_rename_root_is_activated.snap index 746f536dda4..44a428d1274 100644 --- a/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Validation_error_when_rename_root_is_activated.snap +++ b/src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ServerInstrumentationTests.Validation_error_when_rename_root_is_activated.snap @@ -1,4 +1,4 @@ -{ +{ "activities": [ { "OperationName": "ExecuteHttpRequest", @@ -28,12 +28,7 @@ "OperationName": "ParseHttpRequest", "DisplayName": "Parse HTTP Request", "Status": "Ok", - "tags": [ - { - "Key": "otel.status_code", - "Value": "OK" - } - ], + "tags": [], "event": [] }, { @@ -44,10 +39,6 @@ { "Key": "graphql.document.id", "Value": "e2b13c5332af8a70da160fcb96894e5c" - }, - { - "Key": "otel.status_code", - "Value": "ERROR" } ], "event": [], @@ -57,10 +48,6 @@ "DisplayName": "Validate Document", "Status": "Error", "tags": [ - { - "Key": "otel.status_code", - "Value": "ERROR" - }, { "Key": "graphql.document.id", "Value": "e2b13c5332af8a70da160fcb96894e5c"