diff --git a/.editorconfig b/.editorconfig index e6a99ea7ae0..75ff2d157e0 100644 --- a/.editorconfig +++ b/.editorconfig @@ -299,6 +299,9 @@ roslynator_null_conditional_operator.avoid_negative_boolean_comparison = true dotnet_diagnostic.IDE0031.severity = none # Abstract type should not have public constructors. dotnet_diagnostic.RCS1160.severity = warning +# Unused parameter. +dotnet_diagnostic.RCS1163.severity = warning +dotnet_diagnostic.IDE0060.severity = none # Use constant instead of field. dotnet_diagnostic.RCS1187.severity = warning # Unnecessary usage of verbatim string literal. @@ -332,3 +335,8 @@ dotnet_diagnostic.CA1511.severity = none dotnet_diagnostic.CA1512.severity = none dotnet_diagnostic.CA1513.severity = none dotnet_diagnostic.IDE0057.severity = none + +# Tests +[src/**/test/**/*.cs] +# Unused parameter. +dotnet_diagnostic.RCS1163.severity = none diff --git a/src/GreenDonut/src/GreenDonut.Abstractions/Promise.cs b/src/GreenDonut/src/GreenDonut.Abstractions/Promise.cs index c93e8a2464e..7616f59802c 100644 --- a/src/GreenDonut/src/GreenDonut.Abstractions/Promise.cs +++ b/src/GreenDonut/src/GreenDonut.Abstractions/Promise.cs @@ -172,7 +172,7 @@ public static Promise Create(bool cloned = false) /// Returns a new instance of . /// public static Promise Create(TValue value, bool cloned = true) - => new(System.Threading.Tasks.Task.FromResult(value), null, isClone: true); + => new(System.Threading.Tasks.Task.FromResult(value), null, isClone: cloned); /// /// Implicitly converts a to a promise. diff --git a/src/GreenDonut/src/GreenDonut.Data.EntityFramework/Extensions/PagingQueryableExtensions.cs b/src/GreenDonut/src/GreenDonut.Data.EntityFramework/Extensions/PagingQueryableExtensions.cs index b3e4416c99d..5999385a0bf 100644 --- a/src/GreenDonut/src/GreenDonut.Data.EntityFramework/Extensions/PagingQueryableExtensions.cs +++ b/src/GreenDonut/src/GreenDonut.Data.EntityFramework/Extensions/PagingQueryableExtensions.cs @@ -831,7 +831,7 @@ internal static void SetQueryInterceptor(PagingQueryInterceptor pagingQueryInter s_interceptor.Value.Interceptor = pagingQueryInterceptor; } - internal static void ClearQueryInterceptor(PagingQueryInterceptor pagingQueryInterceptor) + internal static void ClearQueryInterceptor() { if (s_interceptor.Value is not null) { diff --git a/src/GreenDonut/src/GreenDonut.Data.EntityFramework/PagingQueryInterceptor.cs b/src/GreenDonut/src/GreenDonut.Data.EntityFramework/PagingQueryInterceptor.cs index a7729d658cb..6de7e660adc 100644 --- a/src/GreenDonut/src/GreenDonut.Data.EntityFramework/PagingQueryInterceptor.cs +++ b/src/GreenDonut/src/GreenDonut.Data.EntityFramework/PagingQueryInterceptor.cs @@ -33,7 +33,7 @@ public void Dispose() { if (!_disposed) { - PagingQueryableExtensions.ClearQueryInterceptor(this); + PagingQueryableExtensions.ClearQueryInterceptor(); _disposed = true; } } diff --git a/src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/ServerFields.cs b/src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/ServerFields.cs index 1309f6bbfd0..ec0e94ab1eb 100644 --- a/src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/ServerFields.cs +++ b/src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/ServerFields.cs @@ -15,7 +15,7 @@ internal static ObjectFieldConfiguration CreateServiceField(IDescriptorContext c descriptor.Type>>().Resolve(s_service); descriptor.Configuration.PureResolver = Resolve; - static _Service Resolve(IResolverContext ctx) + static _Service Resolve(IResolverContext _) => s_service; return descriptor.CreateConfiguration(); diff --git a/src/HotChocolate/Core/src/Abstractions/Execution/Tasks/ExecutionTask.cs b/src/HotChocolate/Core/src/Abstractions/Execution/Tasks/ExecutionTask.cs index ffe1dd8f594..92595a11bcb 100644 --- a/src/HotChocolate/Core/src/Abstractions/Execution/Tasks/ExecutionTask.cs +++ b/src/HotChocolate/Core/src/Abstractions/Execution/Tasks/ExecutionTask.cs @@ -56,7 +56,7 @@ public void BeginExecute(CancellationToken cancellationToken) } /// - public Task WaitForCompletionAsync(CancellationToken cancellationToken) + public Task WaitForCompletionAsync(CancellationToken _) => _task ?? Task.CompletedTask; private async Task ExecuteInternalAsync(CancellationToken cancellationToken) diff --git a/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/ObjectTypeFileBuilder.cs b/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/ObjectTypeFileBuilder.cs index e0748e42a5f..517f935a361 100644 --- a/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/ObjectTypeFileBuilder.cs +++ b/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/ObjectTypeFileBuilder.cs @@ -114,7 +114,7 @@ protected override void WriteResolversBindingInitialization(IOutputTypeInfo type { if (objectType.NodeResolver.RequiresParameterBindings) { - WriteResolverBindingInitialization(objectType.NodeResolver, typeLookup); + WriteResolverBindingInitialization(objectType.NodeResolver); } WriteIsSelectedInitialization(objectType.NodeResolver); diff --git a/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/TypeFileBuilderBase.cs b/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/TypeFileBuilderBase.cs index 35b6e9b8f6a..68a8c9ad73b 100644 --- a/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/TypeFileBuilderBase.cs +++ b/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/TypeFileBuilderBase.cs @@ -737,12 +737,12 @@ protected virtual void WriteResolversBindingInitialization(IOutputTypeInfo type, { foreach (var resolver in type.Resolvers) { - WriteResolverBindingInitialization(resolver, typeLookup); + WriteResolverBindingInitialization(resolver); WriteIsSelectedInitialization(resolver); } } - protected void WriteResolverBindingInitialization(Resolver resolver, ILocalTypeLookup typeLookup) + protected void WriteResolverBindingInitialization(Resolver resolver) { if (resolver.Member is not IMethodSymbol resolverMethod) { diff --git a/src/HotChocolate/Core/src/Types/Execution/Processing/OperationCompiler.cs b/src/HotChocolate/Core/src/Types/Execution/Processing/OperationCompiler.cs index f4050980bed..bda3fd10888 100644 --- a/src/HotChocolate/Core/src/Types/Execution/Processing/OperationCompiler.cs +++ b/src/HotChocolate/Core/src/Types/Execution/Processing/OperationCompiler.cs @@ -73,7 +73,9 @@ public Operation Compile( string hash, string? operationName, DocumentNode document, +#pragma warning disable RCS1163 // Unused parameter IFeatureProvider context) +#pragma warning restore RCS1163 // Unused parameter { ArgumentException.ThrowIfNullOrWhiteSpace(id); ArgumentNullException.ThrowIfNull(document); diff --git a/src/HotChocolate/Core/src/Types/Execution/ThrowHelper.cs b/src/HotChocolate/Core/src/Types/Execution/ThrowHelper.cs index 4f28b3e933a..c13a1a08207 100644 --- a/src/HotChocolate/Core/src/Types/Execution/ThrowHelper.cs +++ b/src/HotChocolate/Core/src/Types/Execution/ThrowHelper.cs @@ -179,7 +179,9 @@ public static GraphQLException ResolverContext_ArgumentDoesNotExist( public static InvalidOperationException RequestExecutorResolver_SchemaNameDoesNotMatch( string configurationSchemaName, string schemaName) => - new("The schema name must align with the schema name expected by the configuration."); + new( + $"The schema name ({schemaName}) must align with the schema name expected by the " + + $"configuration ({configurationSchemaName})."); public static GraphQLException OperationResolverHelper_NoOperationFound( DocumentNode documentNode) => diff --git a/src/HotChocolate/Core/src/Types/Extensions/SchemaBuilderExtensions.Middleware.cs b/src/HotChocolate/Core/src/Types/Extensions/SchemaBuilderExtensions.Middleware.cs index 56d3dac5a62..5434ffda29d 100644 --- a/src/HotChocolate/Core/src/Types/Extensions/SchemaBuilderExtensions.Middleware.cs +++ b/src/HotChocolate/Core/src/Types/Extensions/SchemaBuilderExtensions.Middleware.cs @@ -28,7 +28,7 @@ public static ISchemaBuilder Map( { return builder.Use( FieldClassMiddlewareFactory.Create( - (s, n) => new MapMiddleware( + (_, n) => new MapMiddleware( n, fieldReference, middleware(n)))); } @@ -39,7 +39,7 @@ public static ISchemaBuilder Map( { return builder.Use( FieldClassMiddlewareFactory.Create( - (s, n) => + (_, n) => { var classMiddleware = FieldClassMiddlewareFactory.Create(); @@ -56,7 +56,7 @@ public static ISchemaBuilder Map( { return builder.Use( FieldClassMiddlewareFactory.Create( - (s, n) => + (_, n) => { var classMiddleware = FieldClassMiddlewareFactory diff --git a/src/HotChocolate/Core/src/Types/Text/Json/ResultElement.cs b/src/HotChocolate/Core/src/Types/Text/Json/ResultElement.cs index 478c38c6f23..057214c4e7e 100644 --- a/src/HotChocolate/Core/src/Types/Text/Json/ResultElement.cs +++ b/src/HotChocolate/Core/src/Types/Text/Json/ResultElement.cs @@ -771,7 +771,7 @@ internal ReadOnlySpan GetRawValue(bool includeQuotes = true) { CheckValidInstance(); - return _parent.GetRawValue(_cursor, includeQuotes: true); + return _parent.GetRawValue(_cursor, includeQuotes); } /// diff --git a/src/HotChocolate/Core/src/Types/Types/Descriptors/TypeReferences/SyntaxTypeReference.cs b/src/HotChocolate/Core/src/Types/Types/Descriptors/TypeReferences/SyntaxTypeReference.cs index 4b6e436ad5d..a1854da3895 100644 --- a/src/HotChocolate/Core/src/Types/Types/Descriptors/TypeReferences/SyntaxTypeReference.cs +++ b/src/HotChocolate/Core/src/Types/Types/Descriptors/TypeReferences/SyntaxTypeReference.cs @@ -125,7 +125,7 @@ public SyntaxTypeReference WithScope(string? scope = null) public SyntaxTypeReference WithFactory( Func? factory = null) - => new(Type, Context, Scope, Factory); + => new(Type, Context, Scope, factory); public SyntaxTypeReference With( Optional type = default, diff --git a/src/HotChocolate/Core/src/Types/Types/Relay/NodeFieldResolvers.cs b/src/HotChocolate/Core/src/Types/Types/Relay/NodeFieldResolvers.cs index 3df7feb237f..bf3855a1538 100644 --- a/src/HotChocolate/Core/src/Types/Types/Relay/NodeFieldResolvers.cs +++ b/src/HotChocolate/Core/src/Types/Types/Relay/NodeFieldResolvers.cs @@ -38,12 +38,7 @@ public static async ValueTask ResolveSingleNodeAsync( } else { - context.ReportError( - ErrorHelper.Relay_NoNodeResolver( - typeName, - context.Path, - context.Selection)); - + context.ReportError(ErrorHelper.Relay_NoNodeResolver(typeName, context.Path)); context.Result = null; } } @@ -66,7 +61,6 @@ public static async ValueTask ResolveManyNodeAsync( { context.ReportError( ErrorHelper.FetchedToManyNodesAtOnce( - context.Selection, context.Path, maxAllowedNodes, list.Items.Count)); @@ -99,11 +93,7 @@ public static async ValueTask ResolveManyNodeAsync( { tasks[i] = s_nullTask; - context.ReportError( - ErrorHelper.Relay_NoNodeResolver( - typeName, - context.Path, - context.Selection)); + context.ReportError(ErrorHelper.Relay_NoNodeResolver(typeName, context.Path)); } } @@ -183,11 +173,7 @@ public static async ValueTask ResolveManyNodeAsync( { results[0] = null; - context.ReportError( - ErrorHelper.Relay_NoNodeResolver( - typeName, - context.Path, - context.Selection)); + context.ReportError(ErrorHelper.Relay_NoNodeResolver(typeName, context.Path)); } context.Result = results; diff --git a/src/HotChocolate/Core/src/Types/Utilities/ErrorHelper.cs b/src/HotChocolate/Core/src/Types/Utilities/ErrorHelper.cs index 15e2c1cc94e..26c9a6ac0d6 100644 --- a/src/HotChocolate/Core/src/Types/Utilities/ErrorHelper.cs +++ b/src/HotChocolate/Core/src/Types/Utilities/ErrorHelper.cs @@ -453,7 +453,7 @@ public static ISchemaError NoSchemaTypesAllowedAsRuntimeType( .SetTypeSystemObject(type) .Build(); - public static IError Relay_NoNodeResolver(string typeName, Path path, Selection selection) + public static IError Relay_NoNodeResolver(string typeName, Path path) => ErrorBuilder.New() .SetMessage(ErrorHelper_Relay_NoNodeResolver, typeName) .SetPath(path) @@ -494,7 +494,6 @@ public static ISchemaError NodeResolverMissing( .Build(); public static IError FetchedToManyNodesAtOnce( - Selection selection, Path path, int maxAllowedNodes, int requestNodes) diff --git a/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/List/QueryableListAllOperationHandler.cs b/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/List/QueryableListAllOperationHandler.cs index 34b53098834..2934cf84a43 100644 --- a/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/List/QueryableListAllOperationHandler.cs +++ b/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/List/QueryableListAllOperationHandler.cs @@ -15,5 +15,5 @@ protected override Expression HandleListOperation( LambdaExpression lambda) => FilterExpressionBuilder.All(closureType, context.GetInstance(), lambda); - public static QueryableListAllOperationHandler Create(FilterProviderContext context) => new(); + public static QueryableListAllOperationHandler Create(FilterProviderContext _) => new(); } diff --git a/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/List/QueryableListNoneOperationHandler.cs b/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/List/QueryableListNoneOperationHandler.cs index 672f314859b..8877c89e33f 100644 --- a/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/List/QueryableListNoneOperationHandler.cs +++ b/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/List/QueryableListNoneOperationHandler.cs @@ -16,5 +16,5 @@ protected override Expression HandleListOperation( FilterExpressionBuilder.Not( FilterExpressionBuilder.Any(closureType, context.GetInstance(), lambda)); - public static QueryableListNoneOperationHandler Create(FilterProviderContext context) => new(); + public static QueryableListNoneOperationHandler Create(FilterProviderContext _) => new(); } diff --git a/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/List/QueryableListSomeOperationHandler.cs b/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/List/QueryableListSomeOperationHandler.cs index dc3812363e5..fcdd45ff612 100644 --- a/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/List/QueryableListSomeOperationHandler.cs +++ b/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/List/QueryableListSomeOperationHandler.cs @@ -15,5 +15,5 @@ protected override Expression HandleListOperation( LambdaExpression lambda) => FilterExpressionBuilder.Any(closureType, context.GetInstance(), lambda); - public static QueryableListSomeOperationHandler Create(FilterProviderContext context) => new(); + public static QueryableListSomeOperationHandler Create(FilterProviderContext _) => new(); } diff --git a/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/QueryableDataOperationHandler.cs b/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/QueryableDataOperationHandler.cs index 0ac4857a713..2359ef518df 100644 --- a/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/QueryableDataOperationHandler.cs +++ b/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/QueryableDataOperationHandler.cs @@ -17,5 +17,5 @@ public override bool CanHandle( && def.Id == Operation; } - public static QueryableDataOperationHandler Create(FilterProviderContext context) => new(); + public static QueryableDataOperationHandler Create(FilterProviderContext _) => new(); } diff --git a/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/QueryableDefaultFieldHandler.cs b/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/QueryableDefaultFieldHandler.cs index 72d1d84fa3b..fdfab0a0a1a 100644 --- a/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/QueryableDefaultFieldHandler.cs +++ b/src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/QueryableDefaultFieldHandler.cs @@ -146,7 +146,7 @@ public override bool TryHandleLeave( return true; } - public static QueryableDefaultFieldHandler Create(FilterProviderContext context) => new(); + public static QueryableDefaultFieldHandler Create(FilterProviderContext _) => new(); private sealed class ReplaceVariableExpressionVisitor : ExpressionVisitor { diff --git a/src/HotChocolate/Data/src/Data/Filters/Extensions/FilterSchemaBuilderExtensions.cs b/src/HotChocolate/Data/src/Data/Filters/Extensions/FilterSchemaBuilderExtensions.cs index 5bc335eeae1..869f5f0294c 100644 --- a/src/HotChocolate/Data/src/Data/Filters/Extensions/FilterSchemaBuilderExtensions.cs +++ b/src/HotChocolate/Data/src/Data/Filters/Extensions/FilterSchemaBuilderExtensions.cs @@ -47,7 +47,7 @@ public static ISchemaBuilder AddFiltering( Action configure, string? name = null) => builder - .TryAddConvention(sp => new FilterConvention(configure), name) + .TryAddConvention(_ => new FilterConvention(configure), name) .TryAddTypeInterceptor() .TryAddTypeInterceptor(); diff --git a/src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionFieldHandler.cs b/src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionFieldHandler.cs index 0b32ac9b43e..38abddc3979 100644 --- a/src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionFieldHandler.cs +++ b/src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionFieldHandler.cs @@ -120,5 +120,5 @@ public override bool TryHandleLeave( return true; } - public static QueryableProjectionFieldHandler Create(ProjectionProviderContext context) => new(); + public static QueryableProjectionFieldHandler Create(ProjectionProviderContext _) => new(); } diff --git a/src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionListHandler.cs b/src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionListHandler.cs index 389adbfd75c..9bd165df806 100644 --- a/src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionListHandler.cs +++ b/src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionListHandler.cs @@ -101,5 +101,5 @@ public override bool TryHandleLeave( return true; } - public static QueryableProjectionListHandler Create(ProjectionProviderContext context) => new(); + public static QueryableProjectionListHandler Create(ProjectionProviderContext _) => new(); } diff --git a/src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionScalarHandler.cs b/src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionScalarHandler.cs index a91ef60c6e9..43745efc754 100644 --- a/src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionScalarHandler.cs +++ b/src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionScalarHandler.cs @@ -175,5 +175,5 @@ or ExpressionType.TypeAs } } - public static QueryableProjectionScalarHandler Create(ProjectionProviderContext context) => new(); + public static QueryableProjectionScalarHandler Create(ProjectionProviderContext _) => new(); } diff --git a/src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableFilterInterceptor.cs b/src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableFilterInterceptor.cs index ce707b212db..7bbe6526716 100644 --- a/src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableFilterInterceptor.cs +++ b/src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableFilterInterceptor.cs @@ -67,5 +67,5 @@ public void AfterProjection(QueryableProjectionContext context, Selection select { } - public static QueryableFilterInterceptor Create(ProjectionProviderContext context) => new(); + public static QueryableFilterInterceptor Create(ProjectionProviderContext _) => new(); } diff --git a/src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableFirstOrDefaultInterceptor.cs b/src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableFirstOrDefaultInterceptor.cs index 8fd3d0c6a8a..ddfa52cd34c 100644 --- a/src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableFirstOrDefaultInterceptor.cs +++ b/src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableFirstOrDefaultInterceptor.cs @@ -8,5 +8,5 @@ public QueryableFirstOrDefaultInterceptor() { } - public static QueryableFirstOrDefaultInterceptor Create(ProjectionProviderContext context) => new(); + public static QueryableFirstOrDefaultInterceptor Create(ProjectionProviderContext _) => new(); } diff --git a/src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableSingleOrDefaultInterceptor.cs b/src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableSingleOrDefaultInterceptor.cs index 28e8c5982bc..fafb22e4864 100644 --- a/src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableSingleOrDefaultInterceptor.cs +++ b/src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableSingleOrDefaultInterceptor.cs @@ -9,5 +9,5 @@ public QueryableSingleOrDefaultInterceptor() { } - public static QueryableSingleOrDefaultInterceptor Create(ProjectionProviderContext context) => new(); + public static QueryableSingleOrDefaultInterceptor Create(ProjectionProviderContext _) => new(); } diff --git a/src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableSortInterceptor.cs b/src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableSortInterceptor.cs index 3051f34d423..38e08e29177 100644 --- a/src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableSortInterceptor.cs +++ b/src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableSortInterceptor.cs @@ -55,5 +55,5 @@ public void AfterProjection(QueryableProjectionContext context, Selection select { } - public static QueryableSortInterceptor Create(ProjectionProviderContext context) => new(); + public static QueryableSortInterceptor Create(ProjectionProviderContext _) => new(); } diff --git a/src/HotChocolate/Data/src/Data/Projections/Expressions/Optimizers/QueryableFilterProjectionOptimizer.cs b/src/HotChocolate/Data/src/Data/Projections/Expressions/Optimizers/QueryableFilterProjectionOptimizer.cs index 19eec26c72d..d712e73951d 100644 --- a/src/HotChocolate/Data/src/Data/Projections/Expressions/Optimizers/QueryableFilterProjectionOptimizer.cs +++ b/src/HotChocolate/Data/src/Data/Projections/Expressions/Optimizers/QueryableFilterProjectionOptimizer.cs @@ -33,5 +33,5 @@ static FieldDelegate WrappedPipeline(FieldDelegate next) => return selection; } - public static QueryableFilterProjectionOptimizer Create(ProjectionProviderContext context) => new(); + public static QueryableFilterProjectionOptimizer Create(ProjectionProviderContext _) => new(); } diff --git a/src/HotChocolate/Data/src/Data/Projections/Expressions/Optimizers/QueryablePagingProjectionOptimizer.cs b/src/HotChocolate/Data/src/Data/Projections/Expressions/Optimizers/QueryablePagingProjectionOptimizer.cs index acd94f0c25c..99af4c782e1 100644 --- a/src/HotChocolate/Data/src/Data/Projections/Expressions/Optimizers/QueryablePagingProjectionOptimizer.cs +++ b/src/HotChocolate/Data/src/Data/Projections/Expressions/Optimizers/QueryablePagingProjectionOptimizer.cs @@ -170,5 +170,5 @@ private static void CollectSelectionOfNodes( ? new SelectionSetNode(((SelectionSetNode)n).Selections) : n); - public static QueryablePagingProjectionOptimizer Create(ProjectionProviderContext context) => new(); + public static QueryablePagingProjectionOptimizer Create(ProjectionProviderContext _) => new(); } diff --git a/src/HotChocolate/Data/src/Data/Projections/Expressions/Optimizers/QueryableSortProjectionOptimizer.cs b/src/HotChocolate/Data/src/Data/Projections/Expressions/Optimizers/QueryableSortProjectionOptimizer.cs index d8e2e96e6a1..65d801c31c0 100644 --- a/src/HotChocolate/Data/src/Data/Projections/Expressions/Optimizers/QueryableSortProjectionOptimizer.cs +++ b/src/HotChocolate/Data/src/Data/Projections/Expressions/Optimizers/QueryableSortProjectionOptimizer.cs @@ -32,5 +32,5 @@ static FieldDelegate WrappedPipeline(FieldDelegate next) return selection; } - public static QueryableSortProjectionOptimizer Create(ProjectionProviderContext context) => new(); + public static QueryableSortProjectionOptimizer Create(ProjectionProviderContext _) => new(); } diff --git a/src/HotChocolate/Data/src/Data/Projections/Extensions/ProjectionsSchemaBuilderExtensions.cs b/src/HotChocolate/Data/src/Data/Projections/Extensions/ProjectionsSchemaBuilderExtensions.cs index 792f497b12a..88d93aefd2a 100644 --- a/src/HotChocolate/Data/src/Data/Projections/Extensions/ProjectionsSchemaBuilderExtensions.cs +++ b/src/HotChocolate/Data/src/Data/Projections/Extensions/ProjectionsSchemaBuilderExtensions.cs @@ -43,7 +43,7 @@ public static ISchemaBuilder AddProjections( builder .TryAddTypeInterceptor() .TryAddConvention( - sp => new ProjectionConvention(configure), + _ => new ProjectionConvention(configure), name); /// diff --git a/src/HotChocolate/Data/src/Data/Projections/Optimizers/IsProjectedProjectionOptimizer.cs b/src/HotChocolate/Data/src/Data/Projections/Optimizers/IsProjectedProjectionOptimizer.cs index 34160f1f113..8efdf4f47ac 100644 --- a/src/HotChocolate/Data/src/Data/Projections/Optimizers/IsProjectedProjectionOptimizer.cs +++ b/src/HotChocolate/Data/src/Data/Projections/Optimizers/IsProjectedProjectionOptimizer.cs @@ -74,5 +74,5 @@ [new FieldSelectionNode(fieldNode, 0)], return selection; } - public static IsProjectedProjectionOptimizer Create(ProjectionProviderContext context) => new(); + public static IsProjectedProjectionOptimizer Create(ProjectionProviderContext _) => new(); } diff --git a/src/HotChocolate/Data/src/Data/Projections/Optimizers/QueryableRequirementsProjectionOptimizer.cs b/src/HotChocolate/Data/src/Data/Projections/Optimizers/QueryableRequirementsProjectionOptimizer.cs index cb045de0e26..deaa4c00529 100644 --- a/src/HotChocolate/Data/src/Data/Projections/Optimizers/QueryableRequirementsProjectionOptimizer.cs +++ b/src/HotChocolate/Data/src/Data/Projections/Optimizers/QueryableRequirementsProjectionOptimizer.cs @@ -258,5 +258,5 @@ private static string ToCamelCase(string value) return char.ToLowerInvariant(value[0]) + value[1..]; } - public static QueryableRequirementsProjectionOptimizer Create(ProjectionProviderContext context) => new(); + public static QueryableRequirementsProjectionOptimizer Create(ProjectionProviderContext _) => new(); } diff --git a/src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableAscendingSortOperationHandler.cs b/src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableAscendingSortOperationHandler.cs index 627a78ad34e..2f54c41f575 100644 --- a/src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableAscendingSortOperationHandler.cs +++ b/src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableAscendingSortOperationHandler.cs @@ -15,7 +15,7 @@ protected override QueryableSortOperation HandleOperation( SortEnumValue? sortEnumValue) => AscendingSortOperation.From(fieldSelector); - public static QueryableAscendingSortOperationHandler Create(SortProviderContext context) => new(); + public static QueryableAscendingSortOperationHandler Create(SortProviderContext _) => new(); private sealed class AscendingSortOperation : QueryableSortOperation { diff --git a/src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableDefaultSortFieldHandler.cs b/src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableDefaultSortFieldHandler.cs index 74905f284d5..848a49d8278 100644 --- a/src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableDefaultSortFieldHandler.cs +++ b/src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableDefaultSortFieldHandler.cs @@ -102,7 +102,7 @@ public override bool TryHandleLeave( return true; } - public static QueryableDefaultSortFieldHandler Create(SortProviderContext context) => new(); + public static QueryableDefaultSortFieldHandler Create(SortProviderContext _) => new(); private sealed class ReplaceVariableExpressionVisitor : ExpressionVisitor { diff --git a/src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableDescendingSortOperationHandler.cs b/src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableDescendingSortOperationHandler.cs index 1b52a4c1ef0..fc35d84d30a 100644 --- a/src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableDescendingSortOperationHandler.cs +++ b/src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableDescendingSortOperationHandler.cs @@ -15,7 +15,7 @@ protected override QueryableSortOperation HandleOperation( SortEnumValue? sortEnumValue) => DescendingSortOperation.From(fieldSelector); - public static QueryableDescendingSortOperationHandler Create(SortProviderContext context) => new(); + public static QueryableDescendingSortOperationHandler Create(SortProviderContext _) => new(); private sealed class DescendingSortOperation : QueryableSortOperation { diff --git a/src/HotChocolate/Data/test/Data.Filters.Tests/Mock/MatchAnyFieldHandler.cs b/src/HotChocolate/Data/test/Data.Filters.Tests/Mock/MatchAnyFieldHandler.cs index dacd7851d3c..4106a60e7cb 100644 --- a/src/HotChocolate/Data/test/Data.Filters.Tests/Mock/MatchAnyFieldHandler.cs +++ b/src/HotChocolate/Data/test/Data.Filters.Tests/Mock/MatchAnyFieldHandler.cs @@ -11,5 +11,5 @@ public override bool CanHandle( IFilterInputTypeConfiguration typeConfiguration, IFilterFieldConfiguration fieldConfiguration) => true; - public static MatchAnyQueryableFieldHandler Create(FilterProviderContext context) => new(); + public static MatchAnyQueryableFieldHandler Create(FilterProviderContext _) => new(); } diff --git a/src/HotChocolate/Fusion/benchmarks/k6/eShop.Inventory/ProductNode.cs b/src/HotChocolate/Fusion/benchmarks/k6/eShop.Inventory/ProductNode.cs index 8dfa3d37472..eb49640747d 100644 --- a/src/HotChocolate/Fusion/benchmarks/k6/eShop.Inventory/ProductNode.cs +++ b/src/HotChocolate/Fusion/benchmarks/k6/eShop.Inventory/ProductNode.cs @@ -9,7 +9,6 @@ namespace eShop.Inventory; public static partial class ProductNode { public static long? GetShippingEstimate( - [Parent] Product product, [Require] long weight, [Require] long price) => price > 1000 ? 0 : weight / 2; diff --git a/src/HotChocolate/Fusion/benchmarks/k6/eShop.Reviews/ReviewRepository.cs b/src/HotChocolate/Fusion/benchmarks/k6/eShop.Reviews/ReviewRepository.cs index 934fd386a4e..88d50584a68 100644 --- a/src/HotChocolate/Fusion/benchmarks/k6/eShop.Reviews/ReviewRepository.cs +++ b/src/HotChocolate/Fusion/benchmarks/k6/eShop.Reviews/ReviewRepository.cs @@ -19,7 +19,9 @@ public static class ReviewRepository ]; // Always returns reviews 0 and 1, ignoring the authorId parameter +#pragma warning disable RCS1163 public static IEnumerable GetByUserId(string authorId) +#pragma warning restore RCS1163 => s_reviews.Take(2); public static IEnumerable GetByProductUpc(string upc) diff --git a/src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Nodes/Serialization/JsonOperationPlanParser.cs b/src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Nodes/Serialization/JsonOperationPlanParser.cs index 4cd9e7bec58..f00c3286ba2 100644 --- a/src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Nodes/Serialization/JsonOperationPlanParser.cs +++ b/src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Nodes/Serialization/JsonOperationPlanParser.cs @@ -404,7 +404,7 @@ private static (string? schemaName, OperationSourceText opSource, SelectionPath? List? requirements, string[]? forwardedVariables, SelectionSetNode? resultSelectionSet, int[]? dependencies, int? batchingGroupId, ExecutionNodeCondition[] conditions, bool requiresFileUpload) - ParseCommonOperationFields(JsonElement nodeElement, ISchemaDefinition schema) + ParseCommonOperationFields(JsonElement nodeElement, ISchemaDefinition _) { string? schemaName = null; diff --git a/src/HotChocolate/Fusion/src/Fusion.Execution/Planning/Partitioners/SelectionSetPartitioner.cs b/src/HotChocolate/Fusion/src/Fusion.Execution/Planning/Partitioners/SelectionSetPartitioner.cs index d308fc5b7c1..11539b5e401 100644 --- a/src/HotChocolate/Fusion/src/Fusion.Execution/Planning/Partitioners/SelectionSetPartitioner.cs +++ b/src/HotChocolate/Fusion/src/Fusion.Execution/Planning/Partitioners/SelectionSetPartitioner.cs @@ -244,8 +244,8 @@ void CompleteSelection(T original, T? resolvable, T? unresolvable, int index) } static SelectionSetNode? GetProvidedSelectionSet( - ITypeDefinition type, - FusionSchemaDefinition schema, + ITypeDefinition _1, + FusionSchemaDefinition _2, SelectionSetNode? providedSelectionSetNode) { // todo match correct inline fragment diff --git a/src/HotChocolate/Fusion/src/Fusion.Execution/Text/Json/CompositeResultElement.cs b/src/HotChocolate/Fusion/src/Fusion.Execution/Text/Json/CompositeResultElement.cs index fe5b84fbe48..bd5841b804a 100644 --- a/src/HotChocolate/Fusion/src/Fusion.Execution/Text/Json/CompositeResultElement.cs +++ b/src/HotChocolate/Fusion/src/Fusion.Execution/Text/Json/CompositeResultElement.cs @@ -811,7 +811,7 @@ internal ReadOnlySpan GetRawValue(bool includeQuotes = true) { CheckValidInstance(); - return _parent.GetRawValue(_cursor, includeQuotes: true); + return _parent.GetRawValue(_cursor, includeQuotes); } /// diff --git a/src/HotChocolate/Language/src/Language.SyntaxTree/Utilities/SyntaxPrinter.cs b/src/HotChocolate/Language/src/Language.SyntaxTree/Utilities/SyntaxPrinter.cs index 7598220f5fa..4a68acf252b 100644 --- a/src/HotChocolate/Language/src/Language.SyntaxTree/Utilities/SyntaxPrinter.cs +++ b/src/HotChocolate/Language/src/Language.SyntaxTree/Utilities/SyntaxPrinter.cs @@ -55,7 +55,9 @@ public static async ValueTask PrintToAsync( this ISyntaxNode node, Stream stream, bool indented = true, +#pragma warning disable RCS1163 CancellationToken cancellationToken = default) +#pragma warning restore RCS1163 { #if NETSTANDARD2_0 using var streamWriter = new StreamWriter( diff --git a/src/HotChocolate/MongoDb/src/Data/Filters/Handlers/List/MongoDbListAllOperationHandler.cs b/src/HotChocolate/MongoDb/src/Data/Filters/Handlers/List/MongoDbListAllOperationHandler.cs index bca8dab2304..fe345d78246 100644 --- a/src/HotChocolate/MongoDb/src/Data/Filters/Handlers/List/MongoDbListAllOperationHandler.cs +++ b/src/HotChocolate/MongoDb/src/Data/Filters/Handlers/List/MongoDbListAllOperationHandler.cs @@ -13,7 +13,7 @@ public class MongoDbListAllOperationHandler : MongoDbListOperationHandlerBase /// protected override int Operation => DefaultFilterOperations.All; - public static MongoDbListAllOperationHandler Create(FilterProviderContext context) + public static MongoDbListAllOperationHandler Create(FilterProviderContext _) => new(); /// diff --git a/src/HotChocolate/MongoDb/src/Data/Filters/Handlers/List/MongoDbListNoneOperationHandler.cs b/src/HotChocolate/MongoDb/src/Data/Filters/Handlers/List/MongoDbListNoneOperationHandler.cs index 7b319e5cc71..96c7c19da53 100644 --- a/src/HotChocolate/MongoDb/src/Data/Filters/Handlers/List/MongoDbListNoneOperationHandler.cs +++ b/src/HotChocolate/MongoDb/src/Data/Filters/Handlers/List/MongoDbListNoneOperationHandler.cs @@ -13,7 +13,7 @@ public class MongoDbListNoneOperationHandler : MongoDbListOperationHandlerBase /// protected override int Operation => DefaultFilterOperations.None; - public static MongoDbListNoneOperationHandler Create(FilterProviderContext context) + public static MongoDbListNoneOperationHandler Create(FilterProviderContext _) => new(); /// diff --git a/src/HotChocolate/MongoDb/src/Data/Filters/Handlers/List/MongoDbListSomeOperationHandler.cs b/src/HotChocolate/MongoDb/src/Data/Filters/Handlers/List/MongoDbListSomeOperationHandler.cs index e1db82fcd51..40378160ed2 100644 --- a/src/HotChocolate/MongoDb/src/Data/Filters/Handlers/List/MongoDbListSomeOperationHandler.cs +++ b/src/HotChocolate/MongoDb/src/Data/Filters/Handlers/List/MongoDbListSomeOperationHandler.cs @@ -12,7 +12,7 @@ public class MongoDbListSomeOperationHandler : MongoDbListOperationHandlerBase /// protected override int Operation => DefaultFilterOperations.Some; - public static MongoDbListSomeOperationHandler Create(FilterProviderContext context) + public static MongoDbListSomeOperationHandler Create(FilterProviderContext _) => new(); /// diff --git a/src/HotChocolate/MongoDb/src/Data/Filters/Handlers/MongoDbDefaultFieldHandler.cs b/src/HotChocolate/MongoDb/src/Data/Filters/Handlers/MongoDbDefaultFieldHandler.cs index 5884680119a..b80ab2ffedc 100644 --- a/src/HotChocolate/MongoDb/src/Data/Filters/Handlers/MongoDbDefaultFieldHandler.cs +++ b/src/HotChocolate/MongoDb/src/Data/Filters/Handlers/MongoDbDefaultFieldHandler.cs @@ -13,7 +13,7 @@ namespace HotChocolate.Data.MongoDb.Filters; public class MongoDbDefaultFieldHandler : FilterFieldHandler { - public static MongoDbDefaultFieldHandler Create(FilterProviderContext context) + public static MongoDbDefaultFieldHandler Create(FilterProviderContext _) => new(); /// diff --git a/src/HotChocolate/MongoDb/src/Data/Projections/Convention/Handlers/MongoDbProjectionFieldHandler.cs b/src/HotChocolate/MongoDb/src/Data/Projections/Convention/Handlers/MongoDbProjectionFieldHandler.cs index 92b3f6a017a..2c4e2cc4006 100644 --- a/src/HotChocolate/MongoDb/src/Data/Projections/Convention/Handlers/MongoDbProjectionFieldHandler.cs +++ b/src/HotChocolate/MongoDb/src/Data/Projections/Convention/Handlers/MongoDbProjectionFieldHandler.cs @@ -36,5 +36,5 @@ public override bool TryHandleLeave( return true; } - public static MongoDbProjectionFieldHandler Create(ProjectionProviderContext context) => new(); + public static MongoDbProjectionFieldHandler Create(ProjectionProviderContext _) => new(); } diff --git a/src/HotChocolate/MongoDb/src/Data/Projections/Convention/Handlers/MongoDbProjectionScalarHandler.cs b/src/HotChocolate/MongoDb/src/Data/Projections/Convention/Handlers/MongoDbProjectionScalarHandler.cs index 161bcd5aece..1ccbd01fd37 100644 --- a/src/HotChocolate/MongoDb/src/Data/Projections/Convention/Handlers/MongoDbProjectionScalarHandler.cs +++ b/src/HotChocolate/MongoDb/src/Data/Projections/Convention/Handlers/MongoDbProjectionScalarHandler.cs @@ -29,5 +29,5 @@ public override bool TryHandleEnter( return true; } - public static MongoDbProjectionScalarHandler Create(ProjectionProviderContext context) => new(); + public static MongoDbProjectionScalarHandler Create(ProjectionProviderContext _) => new(); } diff --git a/src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbAscendingSortOperationHandler.cs b/src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbAscendingSortOperationHandler.cs index 1c2325a9272..3901e833a6d 100644 --- a/src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbAscendingSortOperationHandler.cs +++ b/src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbAscendingSortOperationHandler.cs @@ -6,5 +6,5 @@ namespace HotChocolate.Data.MongoDb.Sorting; public class MongoDbAscendingSortOperationHandler() : MongoDbSortOperationHandlerBase(DefaultSortOperations.Ascending, SortDirection.Ascending) { - public static MongoDbAscendingSortOperationHandler Create(SortProviderContext context) => new(); + public static MongoDbAscendingSortOperationHandler Create(SortProviderContext _) => new(); } diff --git a/src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbDefaultSortFieldHandler.cs b/src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbDefaultSortFieldHandler.cs index 1d4ce2c4fba..a938b08bb8a 100644 --- a/src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbDefaultSortFieldHandler.cs +++ b/src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbDefaultSortFieldHandler.cs @@ -50,5 +50,5 @@ public override bool TryHandleLeave( return true; } - public static MongoDbDefaultSortFieldHandler Create(SortProviderContext context) => new(); + public static MongoDbDefaultSortFieldHandler Create(SortProviderContext _) => new(); } diff --git a/src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbDescendingSortOperationHandler.cs b/src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbDescendingSortOperationHandler.cs index 8b5fd6a8f53..5aa4e7a2789 100644 --- a/src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbDescendingSortOperationHandler.cs +++ b/src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbDescendingSortOperationHandler.cs @@ -6,5 +6,5 @@ namespace HotChocolate.Data.MongoDb.Sorting; public class MongoDbDescendingSortOperationHandler() : MongoDbSortOperationHandlerBase(DefaultSortOperations.Descending, SortDirection.Descending) { - public static MongoDbDescendingSortOperationHandler Create(SortProviderContext context) => new(); + public static MongoDbDescendingSortOperationHandler Create(SortProviderContext _) => new(); } diff --git a/src/HotChocolate/Spatial/src/Data/Filters/Expressions/Handlers/QueryableSpatialBufferDataHandler.cs b/src/HotChocolate/Spatial/src/Data/Filters/Expressions/Handlers/QueryableSpatialBufferDataHandler.cs index 1eb7f4a18c4..89378457f3e 100644 --- a/src/HotChocolate/Spatial/src/Data/Filters/Expressions/Handlers/QueryableSpatialBufferDataHandler.cs +++ b/src/HotChocolate/Spatial/src/Data/Filters/Expressions/Handlers/QueryableSpatialBufferDataHandler.cs @@ -7,5 +7,5 @@ public class QueryableSpatialBufferDataHandler { protected override int Operation => SpatialFilterOperations.Buffer; - public static new QueryableSpatialBufferDataHandler Create(FilterProviderContext context) => new(); + public static new QueryableSpatialBufferDataHandler Create(FilterProviderContext _) => new(); } diff --git a/src/HotChocolate/Spatial/src/Data/Filters/Expressions/Handlers/QueryableSpatialGeometryDataHandler.cs b/src/HotChocolate/Spatial/src/Data/Filters/Expressions/Handlers/QueryableSpatialGeometryDataHandler.cs index 0aef4bd67af..0ef5416c742 100644 --- a/src/HotChocolate/Spatial/src/Data/Filters/Expressions/Handlers/QueryableSpatialGeometryDataHandler.cs +++ b/src/HotChocolate/Spatial/src/Data/Filters/Expressions/Handlers/QueryableSpatialGeometryDataHandler.cs @@ -6,5 +6,5 @@ public class QueryableSpatialGeometryDataHandler : QueryableDataOperationHandler { protected override int Operation => SpatialFilterOperations.Geometry; - public static new QueryableSpatialGeometryDataHandler Create(FilterProviderContext context) => new(); + public static new QueryableSpatialGeometryDataHandler Create(FilterProviderContext _) => new(); } diff --git a/src/HotChocolate/Spatial/src/Data/Projections/Extensions/Extensions/QueryableSpatialProjectionScalarHandler.cs b/src/HotChocolate/Spatial/src/Data/Projections/Extensions/Extensions/QueryableSpatialProjectionScalarHandler.cs index 9b0808e3d1e..bed9485c9eb 100644 --- a/src/HotChocolate/Spatial/src/Data/Projections/Extensions/Extensions/QueryableSpatialProjectionScalarHandler.cs +++ b/src/HotChocolate/Spatial/src/Data/Projections/Extensions/Extensions/QueryableSpatialProjectionScalarHandler.cs @@ -12,5 +12,5 @@ public override bool CanHandle(Selection selection) => selection.Field.Member is not null && typeof(Geometry).IsAssignableFrom(selection.Field.Member.GetReturnType()); - public static new QueryableSpatialProjectionScalarHandler Create(ProjectionProviderContext context) => new(); + public static new QueryableSpatialProjectionScalarHandler Create(ProjectionProviderContext _) => new(); } diff --git a/src/HotChocolate/Spatial/src/Types/Serialization/GeoJsonGeometrySerializer.cs b/src/HotChocolate/Spatial/src/Types/Serialization/GeoJsonGeometrySerializer.cs index a09bc4e64a7..b5583149927 100644 --- a/src/HotChocolate/Spatial/src/Types/Serialization/GeoJsonGeometrySerializer.cs +++ b/src/HotChocolate/Spatial/src/Types/Serialization/GeoJsonGeometrySerializer.cs @@ -44,7 +44,7 @@ public bool IsValueCompatible(IType type, JsonElement inputValue) return false; } - if (!TryGetGeometryKindFromJson(type, inputValue, out var geometryType)) + if (!TryGetGeometryKindFromJson(inputValue, out var geometryType)) { return false; } @@ -89,7 +89,7 @@ public bool IsValueCompatible(IType type, JsonElement inputValue) throw Serializer_Parse_ValueKindInvalid(type, SyntaxKind.ObjectValue); } - if (!TryGetGeometryKindFromJson(type, inputValue, out var geometryType)) + if (!TryGetGeometryKindFromJson(inputValue, out var geometryType)) { throw Geometry_Parse_InvalidType(type); } @@ -211,7 +211,6 @@ private bool TryGetGeometryKind( } private bool TryGetGeometryKindFromJson( - IType type, JsonElement inputValue, out GeoJsonGeometryType geometryType) { diff --git a/src/HotChocolate/Spatial/src/Types/ThrowHelper.cs b/src/HotChocolate/Spatial/src/Types/ThrowHelper.cs index 434ddbfa1be..d206641c6c4 100644 --- a/src/HotChocolate/Spatial/src/Types/ThrowHelper.cs +++ b/src/HotChocolate/Spatial/src/Types/ThrowHelper.cs @@ -32,7 +32,7 @@ public static LeafCoercionException Serializer_Parse_TypeIsInvalid(IType type) public static LeafCoercionException Serializer_Parse_ValueKindInvalid( IType type, - SyntaxKind syntaxKind) + SyntaxKind _) => new("Resources.Serializer_Parse_TypeIsInvalid", type); public static LeafCoercionException Serializer_CoordinatesIsMissing(IType type) diff --git a/src/Mocha/src/Mocha.Mediator.Abstractions/Unit.cs b/src/Mocha/src/Mocha.Mediator.Abstractions/Unit.cs index 7d458030fd4..13e1cf7441c 100644 --- a/src/Mocha/src/Mocha.Mediator.Abstractions/Unit.cs +++ b/src/Mocha/src/Mocha.Mediator.Abstractions/Unit.cs @@ -34,7 +34,9 @@ namespace Mocha.Mediator; /// The left operand. /// The right operand. /// Always . +#pragma warning disable RCS1163 public static bool operator ==(Unit left, Unit right) => true; +#pragma warning restore RCS1163 /// /// Determines whether two values are not equal. Always returns . @@ -42,7 +44,9 @@ namespace Mocha.Mediator; /// The left operand. /// The right operand. /// Always . +#pragma warning disable RCS1163 public static bool operator !=(Unit left, Unit right) => false; +#pragma warning restore RCS1163 /// /// Gets the default and only value of . diff --git a/src/Mocha/src/Mocha.Transport.RabbitMQ/Middlewares/Receive/RabbitMQAcknowledgementMiddleware.cs b/src/Mocha/src/Mocha.Transport.RabbitMQ/Middlewares/Receive/RabbitMQAcknowledgementMiddleware.cs index 73c1d948bc9..a4ac41192a5 100644 --- a/src/Mocha/src/Mocha.Transport.RabbitMQ/Middlewares/Receive/RabbitMQAcknowledgementMiddleware.cs +++ b/src/Mocha/src/Mocha.Transport.RabbitMQ/Middlewares/Receive/RabbitMQAcknowledgementMiddleware.cs @@ -50,6 +50,6 @@ public async ValueTask InvokeAsync(IReceiveContext context, ReceiveDelegate next /// A middleware configuration keyed as "RabbitMQAcknowledgement". public static ReceiveMiddlewareConfiguration Create() => new( - static (context, next) => ctx => s_instance.InvokeAsync(ctx, next), + static (_, next) => ctx => s_instance.InvokeAsync(ctx, next), "RabbitMQAcknowledgement"); } diff --git a/src/Mocha/src/Mocha/MessageTypes/InboundRoute.cs b/src/Mocha/src/Mocha/MessageTypes/InboundRoute.cs index 9c4d8154d6b..1c6de1b4dba 100644 --- a/src/Mocha/src/Mocha/MessageTypes/InboundRoute.cs +++ b/src/Mocha/src/Mocha/MessageTypes/InboundRoute.cs @@ -92,7 +92,9 @@ public void ConnectEndpoint(IMessagingConfigurationContext context, ReceiveEndpo /// Completes the route initialization, verifying that an endpoint has been connected. /// /// The messaging configuration context. +#pragma warning disable RCS1163 // Unused parameter public void Complete(IMessagingConfigurationContext context) +#pragma warning restore RCS1163 // Unused parameter { AssertInitialized(); AssertNotCompleted(); diff --git a/src/Mocha/src/Mocha/Middlewares/ReceiveContext.cs b/src/Mocha/src/Mocha/Middlewares/ReceiveContext.cs index 2f7715a5f3e..7f9a6e1921f 100644 --- a/src/Mocha/src/Mocha/Middlewares/ReceiveContext.cs +++ b/src/Mocha/src/Mocha/Middlewares/ReceiveContext.cs @@ -233,7 +233,9 @@ public void Initialize( IServiceProvider services, ReceiveEndpoint endpoint, IMessagingRuntime runtime, +#pragma warning disable RCS1163 // Unused parameter CancellationToken cancellationToken) +#pragma warning restore RCS1163 // Unused parameter { Services = services; Endpoint = endpoint; diff --git a/src/Mocha/src/Mocha/Transport/MessagingTransport.Lifecyle.cs b/src/Mocha/src/Mocha/Transport/MessagingTransport.Lifecyle.cs index 8340f6a2499..e443d3daae9 100644 --- a/src/Mocha/src/Mocha/Transport/MessagingTransport.Lifecyle.cs +++ b/src/Mocha/src/Mocha/Transport/MessagingTransport.Lifecyle.cs @@ -283,7 +283,7 @@ internal void Complete(IMessagingSetupContext context) } } - internal void Finalize(IMessagingSetupContext context) + internal void Finalize(IMessagingSetupContext _) { _features = _features?.ToReadOnly() ?? FeatureCollection.Empty; Configuration = null!; diff --git a/src/Nitro/CommandLine/src/CommandLine.FusionCompatibility/FusionGraphPackage.cs b/src/Nitro/CommandLine/src/CommandLine.FusionCompatibility/FusionGraphPackage.cs index b37c2f37f33..b801c6a442f 100644 --- a/src/Nitro/CommandLine/src/CommandLine.FusionCompatibility/FusionGraphPackage.cs +++ b/src/Nitro/CommandLine/src/CommandLine.FusionCompatibility/FusionGraphPackage.cs @@ -433,7 +433,9 @@ public async Task SetSubgraphConfigurationAsync( /// public Task RemoveSubgraphConfigurationAsync( string subgraphName, +#pragma warning disable RCS1163 // Unused parameter CancellationToken cancellationToken = default) +#pragma warning restore RCS1163 // Unused parameter { ArgumentNullException.ThrowIfNull(subgraphName); diff --git a/src/Nitro/CommandLine/src/CommandLine/Commands/OpenApi/ListOpenApiCollectionCommand.cs b/src/Nitro/CommandLine/src/CommandLine/Commands/OpenApi/ListOpenApiCollectionCommand.cs index 0bb40165fb0..7df2d8d1b03 100644 --- a/src/Nitro/CommandLine/src/CommandLine/Commands/OpenApi/ListOpenApiCollectionCommand.cs +++ b/src/Nitro/CommandLine/src/CommandLine/Commands/OpenApi/ListOpenApiCollectionCommand.cs @@ -39,7 +39,14 @@ private static async Task ExecuteAsync( if (console.IsInteractive) { - return await RenderInteractiveAsync(parseResult, console, client, apisClient, sessionService, resultHolder, cursor, ct); + return await RenderInteractiveAsync( + parseResult, + console, + client, + apisClient, + sessionService, + resultHolder, + ct); } return await RenderNonInteractiveAsync(parseResult, client, resultHolder, cursor, ct); @@ -52,7 +59,6 @@ private static async Task RenderInteractiveAsync( IApisClient apisClient, ISessionService sessionService, IResultHolder resultHolder, - string? cursor, CancellationToken ct) { const string apiMessage = "For which API do you want to list the OpenAPI collections?"; diff --git a/src/Nitro/CommandLine/src/CommandLine/Extensions/OptionExtensions.cs b/src/Nitro/CommandLine/src/CommandLine/Extensions/OptionExtensions.cs index af8e862861c..f3b2cb6b945 100644 --- a/src/Nitro/CommandLine/src/CommandLine/Extensions/OptionExtensions.cs +++ b/src/Nitro/CommandLine/src/CommandLine/Extensions/OptionExtensions.cs @@ -68,7 +68,7 @@ public static Option DefaultFromEnvironmentValue( string name, T? defaultValue = default) { - option.DefaultValueFactory = r => + option.DefaultValueFactory = _ => { var provider = CommandExecutionContext.s_services.Value! .GetRequiredService(); diff --git a/src/StrawberryShake/Client/src/Core/CachePolicy.Defaults.cs b/src/StrawberryShake/Client/src/Core/CachePolicy.Defaults.cs index 87ff4d24c5b..dad25bfee00 100644 --- a/src/StrawberryShake/Client/src/Core/CachePolicy.Defaults.cs +++ b/src/StrawberryShake/Client/src/Core/CachePolicy.Defaults.cs @@ -13,7 +13,7 @@ public static CachePolicy Default(IStoreAccessor storeAccessor, TimeSpan timeToL var lastClean = DateTime.UtcNow; var cleaning = false; - return new(storeAccessor.OperationStore.Watch().Subscribe(result => + return new(storeAccessor.OperationStore.Watch().Subscribe(_ => { var time = DateTime.UtcNow; diff --git a/src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Builders/TypeReferenceBuilder.cs b/src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Builders/TypeReferenceBuilder.cs index fed4e971b77..5be492de3e4 100644 --- a/src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Builders/TypeReferenceBuilder.cs +++ b/src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Builders/TypeReferenceBuilder.cs @@ -27,11 +27,6 @@ public TypeReferenceBuilder SkipTrailingSpace() return this; } - public TypeReferenceBuilder SetNameSpace(string @namespace) - { - return this; - } - public TypeReferenceBuilder SetListType() { _buildOrder.Push(TypeKindToken.List); diff --git a/src/StrawberryShake/CodeGeneration/src/CodeGeneration/Analyzers/FieldCollector.cs b/src/StrawberryShake/CodeGeneration/src/CodeGeneration/Analyzers/FieldCollector.cs index 6fdf84008ea..4b012847c20 100644 --- a/src/StrawberryShake/CodeGeneration/src/CodeGeneration/Analyzers/FieldCollector.cs +++ b/src/StrawberryShake/CodeGeneration/src/CodeGeneration/Analyzers/FieldCollector.cs @@ -188,7 +188,7 @@ internal static void ResolveFieldSelection( } } - private static bool IsConditional(IHasDirectives hasDirectives) => false; + private static bool IsConditional(IHasDirectives _) => false; private void ResolveFragmentSpread( FragmentSpreadNode fragmentSpreadSyntax, diff --git a/src/StrawberryShake/CodeGeneration/src/CodeGeneration/ErrorHelper.cs b/src/StrawberryShake/CodeGeneration/src/CodeGeneration/ErrorHelper.cs index 0545d5c2300..e1e47b84c09 100644 --- a/src/StrawberryShake/CodeGeneration/src/CodeGeneration/ErrorHelper.cs +++ b/src/StrawberryShake/CodeGeneration/src/CodeGeneration/ErrorHelper.cs @@ -13,7 +13,9 @@ public static class ErrorHelper public static IError WithFileReference( this IError error, +#pragma warning disable RCS1163 IDictionary fileLookup) +#pragma warning restore RCS1163 { var extensions = ImmutableOrderedDictionary.Empty .Add(TitleExtensionKey, "Schema validation error") diff --git a/src/StrawberryShake/CodeGeneration/src/CodeGeneration/Mappers/StoreAccessorMapper.cs b/src/StrawberryShake/CodeGeneration/src/CodeGeneration/Mappers/StoreAccessorMapper.cs index 6d0a9badefb..f3d30acc1ee 100644 --- a/src/StrawberryShake/CodeGeneration/src/CodeGeneration/Mappers/StoreAccessorMapper.cs +++ b/src/StrawberryShake/CodeGeneration/src/CodeGeneration/Mappers/StoreAccessorMapper.cs @@ -6,7 +6,7 @@ namespace StrawberryShake.CodeGeneration.Mappers; public static class StoreAccessorMapper { public static void Map( - ClientModel model, + ClientModel _, IMapperContext context) { context.Register(