Skip to content

Conversation

@N-Olbert
Copy link
Contributor

@N-Olbert N-Olbert commented Sep 5, 2025

Summary of the changes (Less than 80 chars)

  • Exceptions thrown by type converters while parsing client input are no longer swallowed. Instead, they are:

    • consistently returned to the client / to the outside world using the same error message and code for all kinds of input
    • propagated to the error filter
      • within the error filter, developers can freely decide whether exception details (e.g. the message) should be exposed publicly or not.
  • This is a breaking change, but currently the behavior is inconsistent and depended on the input type used, see Exceptions thrown in type converters are not surfaced #7404 .

  • I did not look at exceptions thrown within the output, as C# is strongly typed and threfore such exceptions are unlikely to be relevant at all.

Closes #7404 (in this specific format)
Closes #6385

@tobias-tengler tobias-tengler requested review from tobias-tengler and removed request for michaelstaib September 17, 2025 10:10
Copy link
Member

@tobias-tengler tobias-tengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @N-Olbert! :)
I left a few comments.

Copy link
Member

@tobias-tengler tobias-tengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you again for your time and thoroughness 🙌

@github-actions github-actions bot added the 📚 documentation This issue is about working on our documentation. label Sep 25, 2025
@tobias-tengler tobias-tengler merged commit ac31ff0 into ChilliCream:main Sep 25, 2025
110 checks passed
@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (6a3b7a3) to head (ee8d74b).
⚠️ Report is 426 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #8677       +/-   ##
==========================================
- Coverage   74.16%       0   -74.17%     
==========================================
  Files        2677       0     -2677     
  Lines      140790       0   -140790     
  Branches    16371       0    -16371     
==========================================
- Hits       104421       0   -104421     
+ Misses      30774       0    -30774     
+ Partials     5595       0     -5595     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 documentation This issue is about working on our documentation. 🌶️ hot chocolate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exceptions thrown in type converters are not surfaced AddTypeConverter<T1, T2> errors result in NotSupportedException but without an inner exception

3 participants