-
-
Notifications
You must be signed in to change notification settings - Fork 799
Reworked / harmonized error handling and propagation for custom TypeConverter-errors #8677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ers. Refactored and added test cases.
tobias-tengler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @N-Olbert! :)
I left a few comments.
src/HotChocolate/Core/src/Execution/Processing/MiddlewareContext.Arguments.cs
Outdated
Show resolved
Hide resolved
- fieldCoordinate -> coordinate - inputPath-Extension
tobias-tengler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you again for your time and thoroughness 🙌
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8677 +/- ##
==========================================
- Coverage 74.16% 0 -74.17%
==========================================
Files 2677 0 -2677
Lines 140790 0 -140790
Branches 16371 0 -16371
==========================================
- Hits 104421 0 -104421
+ Misses 30774 0 -30774
+ Partials 5595 0 -5595
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary of the changes (Less than 80 chars)
Exceptions thrown by type converters while parsing client input are no longer swallowed. Instead, they are:
This is a breaking change, but currently the behavior is inconsistent and depended on the input type used, see Exceptions thrown in type converters are not surfaced #7404 .
I did not look at exceptions thrown within the output, as C# is strongly typed and threfore such exceptions are unlikely to be relevant at all.
Closes #7404 (in this specific format)
Closes #6385