AddRedisQueryStorage Throws & Inconsistent API

[RehanSaeed]

Describe the bug

If I remove x.GetApplicationServices() below, Hot Chocolate is unable to resolve IConnectionMultiplexer and throws an exception.

services.AddSingleton<IConnectionMultiplexer>(ConnectionMultiplexer.Connect("localhost:6379"));

builder.AddRedisQueryStorage(x => x.GetApplicationServices().GetRequiredService<IConnectionMultiplexer>().GetDatabase());

Additionally, there is some inconsistency in the way that we resolve a IConnectionMultiplexer in AddRedisQueryStorage and AddRedisSubscriptions. In one call we have to get a database, while in the other we don't.

builder.AddRedisSubscriptions(x => x.GetRequiredService<IConnectionMultiplexer>());

Expected behavior

The code below should not throw and should be able to resolve IConnectionMultiplexer. Additionally, I suggest removing the additional need to call .GetDatabase() in AddRedisQueryStorage.

services.AddSingleton<IConnectionMultiplexer>(ConnectionMultiplexer.Connect("localhost:6379"));

builder.AddRedisQueryStorage(x => x.GetRequiredService<IConnectionMultiplexer>());

[michaelstaib]

This one is now implemented. We now allow the following:

Variant 1:

services.AddSingleton<IConnectionMultiplexer>(ConnectionMultiplexer.Connect("localhost:6379"));

builder.AddRedisQueryStorage(x => x.GetRequiredService<IConnectionMultiplexer>().GetDatabase());

Variant 2:

services.AddSingleton<IConnectionMultiplexer>(ConnectionMultiplexer.Connect("localhost:6379"));

builder.AddRedisQueryStorage(x => x.GetRequiredService<IConnectionMultiplexer>());

Variant 3:

services.AddSingleton<IConnectionMultiplexer>(ConnectionMultiplexer.Connect("localhost:6379"));

// this will get the first registered multiplexer.
builder.AddRedisQueryStorage();