Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not return unexpected coins from get_coin_state #17850

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Do not return unexpected coins from get_coin_state #17850

merged 6 commits into from
Apr 24, 2024

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented Apr 9, 2024 •
edited
Loading

Previously we could receive states from get_coin_state that were not the state we requested, and this could result in some unexpected behavior.

@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Apr 9, 2024
@Quexington Quexington marked this pull request as ready for review April 9, 2024 21:08
@Quexington Quexington requested a review from a team as a code owner April 9, 2024 21:08
@wjblanke
Copy link
Contributor

wjblanke commented Apr 9, 2024

do you think we should ban this node since it is returning coins we didn't ask for? possibly maliciously? i think this is what bram was concerned about.

@Chia-Network Chia-Network deleted a comment from github-actions bot Apr 10, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Apr 10, 2024
@Quexington Quexington closed this Apr 24, 2024
@Quexington Quexington reopened this Apr 24, 2024
wjblanke
wjblanke approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 8818403709

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 2 files are covered.
  • 30 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.01%) to 91.082%
Files with Coverage Reduction New Missed Lines %
chia/rpc/rpc_server.py 1 89.0%
chia/timelord/timelord_launcher.py 1 69.92%
chia/server/node_discovery.py 3 79.26%
chia/full_node/full_node.py 4 84.87%
chia/introducer/introducer.py 5 79.35%
chia/wallet/wallet_node.py 16 87.07%
Totals Coverage Status
Change from base Build 8809423530: -0.01%
Covered Lines: 98684
Relevant Lines: 108319
💛 - Coveralls

@pmaslana pmaslana merged commit 6c1579c into main Apr 24, 2024
692 checks passed
@pmaslana pmaslana deleted the quex.validate_received_coin_state_list branch April 24, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Quexington @wjblanke @pmaslana