get_block_generator() fork detection #16867
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
fix logic in get_block_generator() that determines whether we're looking up a block from a fork or the main chain.
Current Behavior:
We only consider a block lookup to be in the main chain if its previous block is in the cache.
New Behavior:
We consider block lookups part of the main chain if the previous block is in the database and its hash is the same as the height-to-hash map for that height.
testing
This change was tested by issuing the following RPC command:
in
main
this freezes with this patch it returns the result quickly.