Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync no farmer #16698

Merged
merged 2 commits into from
Oct 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion chia/full_node/full_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -897,8 +897,9 @@ async def _sync(self) -> None:
self.log.info("Waiting to receive peaks from peers.")

# Wait until we have 3 peaks or up to a max of 30 seconds
max_iterations = int(self.config.get("max_sync_wait", 30)) * 10
peaks = []
for i in range(300):
for i in range(max_iterations):
peaks = [peak.header_hash for peak in self.sync_store.get_peak_of_each_peer().values()]
if len(self.sync_store.get_peers_that_have_peak(peaks)) < 3:
if self._shut_down:
Expand Down
4 changes: 4 additions & 0 deletions chia/simulator/setup_nodes.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,10 @@ async def setup_simulators_and_wallets(
disable_capabilities: Optional[List[Capability]] = None,
) -> AsyncIterator[Tuple[List[FullNodeSimulator], List[Tuple[WalletNode, ChiaServer]], BlockTools]]:
with TempKeyring(populate=True) as keychain1, TempKeyring(populate=True) as keychain2:
if config_overrides is None:
config_overrides = {}
if "full_node.max_sync_wait" not in config_overrides:
config_overrides["full_node.max_sync_wait"] = 1
async with setup_simulators_and_wallets_inner(
db_version,
consensus_constants,
Expand Down
4 changes: 4 additions & 0 deletions chia/util/initial-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,10 @@ full_node:
# timeout for weight proof request
weight_proof_timeout: &weight_proof_timeout 360

# when the full node enters sync-mode, we wait until we have collected peaks
# from at least 3 peers, or until we've waitied this many seconds
max_sync_wait: 30

# when enabled, the full node will print a pstats profile to the root_dir/profile every second
# analyze with chia/utils/profiler.py
enable_profiler: False
Expand Down
40 changes: 40 additions & 0 deletions tests/core/full_node/test_full_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
from chia.util.hash import std_hash
from chia.util.ints import uint8, uint16, uint32, uint64, uint128
from chia.util.limited_semaphore import LimitedSemaphore
from chia.util.misc import to_batches
from chia.util.recursive_replace import recursive_replace
from chia.util.vdf_prover import get_vdf_info_and_proof
from chia.wallet.util.tx_config import DEFAULT_TX_CONFIG
Expand Down Expand Up @@ -106,6 +107,45 @@ async def get_block_path(full_node: FullNodeAPI):
return blocks_list


@pytest.mark.asyncio
async def test_sync_no_farmer(
setup_two_nodes_and_wallet,
default_1000_blocks: List[FullBlock],
self_hostname: str,
seeded_random: random.Random,
):
nodes, wallets, bt = setup_two_nodes_and_wallet
server_1 = nodes[0].full_node.server
server_2 = nodes[1].full_node.server
full_node_1 = nodes[0]
full_node_2 = nodes[1]

blocks = default_1000_blocks

# full node 1 has the complete chain
for block_batch in to_batches(blocks, 64):
await full_node_1.full_node.add_block_batch(block_batch.entries, PeerInfo("0.0.0.0", 8884), None)

target_peak = full_node_1.full_node.blockchain.get_peak()

# full node 2 is behind by 800 blocks
for block_batch in to_batches(blocks[:-800], 64):
await full_node_2.full_node.add_block_batch(block_batch.entries, PeerInfo("0.0.0.0", 8884), None)

# connect the nodes and wait for node 2 to sync up to node 1
await connect_and_get_peer(server_1, server_2, self_hostname)

def check_nodes_in_sync():
p1 = full_node_2.full_node.blockchain.get_peak()
p2 = full_node_1.full_node.blockchain.get_peak()
return p1 == p2

await time_out_assert(40, check_nodes_in_sync)

assert full_node_1.full_node.blockchain.get_peak() == target_peak
assert full_node_2.full_node.blockchain.get_peak() == target_peak


class TestFullNodeBlockCompression:
@pytest.mark.asyncio
@pytest.mark.parametrize("tx_size", [3000000000000])
Expand Down