require SerializedProgram.from_bytes() is passed a valid clvm structure #16674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
The Streamable protocol (normally) requires input passed to
parse()
andfrom_bytes()
be equally valid input. The distinction is thatparse()
consumes input from a stream, whereasfrom_bytes()
expects the complete byte buffer to represent the complete value to be consumed for the streamable type.SerializedProgram
is currently an exception to this, where there is no validation at all of the input passed tofrom_bytes()
, whereasparse()
does validate the input. In most normal production use,parse()
is howSerializedProgram
s are initialized (such as parsing aFullBlock
from the network or database).There are however a few tests where we initialize
SerializedProgram
with invalid input. This is a small tweak to correct this quirk, and fix the tests.Current Behavior:
SerializedProgram.from_bytes(b"aaa")
is valid.New Behavior:
SerializedProgram.from_bytes(b"aaa")
is not valid.