You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You could be a little less fancy here - keep the regex match, then just str.replace()[ and ]#16660 (files)
I don't quite follow, but also this code is... not exactly clear about the purpose. It is meant to take the parametrization of the form [a-b-c] for the three parameter ids a, b, and c and remove a parametrization id of the form benchmark_repeat000 regardless of it being the only item, first item, middle item, or last item. Basically to get back to the parametrization as it would be presented if there were no benchmark repeat fixture parametrization in use. All without ending up with -- or [- or -]. But maybe that's what you're saying. Let those happen and then just do three replaces to catch those cases?
I probably ought to just do this on the test run side of things and then record that as another property in the results. I expect I would be able to do it there without any string manipulation.
AddedRequired label for PR that categorizes merge commit message as "Added" for changelogCICI changes
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
Current Behavior:
New Behavior:
https://github.com/Chia-Network/chia-blockchain/actions/runs/6616802037?pr=16660#summary-17971786470
Testing Notes: