Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkpoint: into main from release/2.1.0 @ d2934682ecc4a96c6b4641e8a68f48d5446787ea #16446

Conversation

altendky
Copy link
Contributor

Source hash: d293468
Remaining commits: 9

xearl4 and others added 2 commits September 25, 2023 16:35
…16387)

* Fix `chia farm summary` aborting early if no local full node present

Before 2.0, even if no local full node was present, `chia farm summary`
would still show useful information:

	$ chia farm summary
	Farming status: Not available
	Local Harvester
	   1 plots of size: 101.320 GiB on-disk, 101.400 GiBe (effective)
	Plot count for all harvesters: 1
	Total size of plots: 101.320 GiB, 101.400 GiBe (effective)
	Estimated network space: Unknown
	Expected time to win: Unknown
	For details on farmed rewards and fees you should run 'chia start wallet' and 'chia wallet show'

However, since 2.0, that is no longer the case. `chia farm summary`
simply aborts with an exception:

	$ chia farm summary
	Error: Connection error: ClientConnectorError: Cannot connect to host localhost:8555 ssl:<ssl.SSLContext object at 0x7fe0edd533c0> [Connect call failed ('127.0.0.1', 8555)]
	Check if full node rpc is running at 8555
	This is normal if full node is still starting up

This fixes this particular regression which is rather annoying for
farmers farming to a remote node.

Fixes #16164. Related to issue #9615, but that issue is wider in scope.

* Improve exception reporting for `chia farm summary`

With this change, only the exceptions when failing to connect to a local
full node and/or wallet are suppressed, as these cases are already
properly handled by adjusted command output. Any other exception is
printed to stderr.
…nt/main_from_release_2.1.0_d2934682ecc4a96c6b4641e8a68f48d5446787ea
@altendky altendky requested a review from a team as a code owner September 27, 2023 20:29
@altendky altendky added checkpoint_merge Changed Required label for PR that categorizes merge commit message as "Changed" for changelog labels Sep 27, 2023
@github-actions
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/farm_funcs.py 40.0% lines 98-102, 110, 112-114
Total Missing Coverage
15 lines 9 lines 40%

@wallentx wallentx merged commit 0730e2e into main Sep 28, 2023
234 of 235 checks passed
@wallentx wallentx deleted the checkpoint/main_from_release_2.1.0_d2934682ecc4a96c6b4641e8a68f48d5446787ea branch September 28, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog checkpoint_merge coverage-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants