Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: improve tw Traditional Chinese locale #5602

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

PeterDaveHello
Copy link
Contributor

@PeterDaveHello PeterDaveHello commented Oct 8, 2024

💻 变更类型 | Change Type

  • feat
  • fix
  • refactor
  • perf
  • style
  • test
  • docs
  • ci
  • chore
  • build

🔀 变更说明 | Description of Change

Some minor updates for zh-tw locale.

Summary by CodeRabbit

  • New Features

    • Improved localization by refining translations for error messages, tips, and UI labels.
    • Enhanced clarity and consistency in terminology across various phrases.
  • Bug Fixes

    • Adjusted wording for better user understanding in error messages and prompts.

Copy link

vercel bot commented Oct 8, 2024

@PeterDaveHello is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Oct 8, 2024

Walkthrough

The pull request primarily updates the localization file tw.ts, enhancing the clarity and consistency of various translations from Chinese. Key modifications include changes to error messages, UI labels, and terminology adjustments, such as replacing specific phrases and refining language for better user understanding. Additionally, type declarations for LocaleType and PartialLocaleType have been updated to reflect these changes.

Changes

File Change Summary
app/locales/tw.ts - Updated various strings for consistency and clarity in translations.
- Changed "點擊這裡" to "點選這裡"; "存取金鑰" to "訪問秘鑰"; "刷新標題" to "重新整理標題".
- Adjusted error messages and UI labels for better user understanding.
- Updated type declarations: LocaleType and PartialLocaleType.

Possibly related PRs

  • Improve tw Traditional Chinese locale #4933: This PR involves changes to the same localization file app/locales/tw.ts, focusing on improving the Traditional Chinese locale, which aligns with the main PR's updates to the same file for clarity and consistency in translations.

Suggested reviewers

  • Dogtiti

Poem

🐇 In the land of words, we hop and play,
With phrases refined, we brighten the day.
From "點擊" to "點選," our language aligns,
A clearer path for all, as our meaning shines!
So let’s celebrate with a joyful cheer,
For every change brings us closer, my dear! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
app/locales/tw.ts (2)

28-30: Enhanced user guidance and promotional message

The additions provide more user-friendly options and specific information about available AI models, which is beneficial for user engagement. However, consider the following suggestion:

Consider adding a translation comment for the "NextChat AI" brand name to ensure consistency across different language versions. For example:

 TopTips:
-      "🥳 NextChat AI 首發優惠,立刻解鎖 OpenAI o1, GPT-4o, Claude-3.5 等最新的大型語言模型",
+      "🥳 NextChat AI 首發優惠,立刻解鎖 OpenAI o1, GPT-4o, Claude-3.5 等最新的大型語言模型", // NextChat AI: Do not translate

304-305: Enhanced product description and call-to-action

The changes provide more specific information about available AI models and add a clear call-to-action, which should improve user engagement. However, consider the following suggestion:

Consider adding a translation comment for the AI model names to ensure consistency across different language versions. For example:

 SubTitle:
-          "由 NextChat 官方維護,無須設定開箱即用,支援 OpenAI o1、GPT-4o、Claude-3.5 等最新的大型語言模型",
+          "由 NextChat 官方維護,無須設定開箱即用,支援 OpenAI o1、GPT-4o、Claude-3.5 等最新的大型語言模型", // OpenAI o1, GPT-4o, Claude-3.5: Do not translate
 ChatNow: "立刻開始對話",
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 8ad63a6 and 77a58bc.

📒 Files selected for processing (1)
  • app/locales/tw.ts (7 hunks)
🧰 Additional context used
🔇 Additional comments (7)
app/locales/tw.ts (7)

11-16: Improved terminology consistency and clarity

The changes in these lines enhance the consistency of terminology and potentially improve clarity for Traditional Chinese users. The adjustment from "點擊" to "點選" and "存取金鑰" to "訪問秘鑰" are minor but meaningful improvements.


56-57: Improved language consistency

The changes from "刷新" to "重新整理" and "發送" to "傳送" are appropriate adjustments for Traditional Chinese usage. These modifications enhance the natural flow of the language for Taiwanese users.


98-101: Enhanced precision in action descriptions

The changes in these lines improve the clarity of the described actions. "開啟新聊天" more accurately describes the action of starting a new chat, while "複製最後一個程式碼區塊" provides a more precise description of copying the last code block.


177-179: Improved terminology for font settings

The changes in these lines enhance the accuracy of the terminology used for font settings. The use of "字型" instead of "字體" is more appropriate in Traditional Chinese, and the addition of "聊天" in the title provides clearer context for the setting.


488-494: Improved Traditional Chinese localization

The changes in the "SearchChat" section enhance the use of Traditional Chinese terminology. The updates from "搜索" to "搜尋" and "加載中" to "載入中" are more appropriate and commonly used in Traditional Chinese, improving the overall language consistency and user experience for Taiwanese users.

Also applies to: 499-499


Line range hint 545-553: Type declarations remain consistent

The type declarations at the end of the file have been maintained correctly, ensuring consistency with the changes made to the localization strings throughout the file.


Line range hint 1-553: Overall improvement in Traditional Chinese localization

The changes made to this file consistently enhance the quality of the Traditional Chinese (Taiwan) localization. The updates improve terminology consistency, clarity, and user-friendliness. The modifications align well with common Traditional Chinese usage and should provide a better experience for Taiwanese users.

Key improvements include:

  1. More accurate and natural language choices
  2. Enhanced clarity in user instructions and settings descriptions
  3. Updated terminology for better consistency
  4. Improved specificity in certain feature descriptions

The suggested minor improvements, such as adding translation comments for brand and model names, would further enhance maintainability across different language versions.

Overall, these changes are well-considered and beneficial to the localization quality.

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Your build has completed!

Preview deployment

@Dogtiti Dogtiti requested a review from Leizhenpeng October 9, 2024 03:07
@lloydzhou lloydzhou merged commit fbc68fa into ChatGPTNextWeb:main Oct 9, 2024
1 of 2 checks passed
@PeterDaveHello PeterDaveHello deleted the ImproveTwLocale branch October 9, 2024 12:47
This was referenced Oct 11, 2024
@coderabbitai coderabbitai bot mentioned this pull request Nov 15, 2024
10 tasks
This was referenced Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants