Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bypassing docker build in the build.rs file for quicker builds. #10

Closed
stonecharioteer opened this issue Mar 20, 2023 · 0 comments · Fixed by #11
Closed

Allow bypassing docker build in the build.rs file for quicker builds. #10

stonecharioteer opened this issue Mar 20, 2023 · 0 comments · Fixed by #11

Comments

@stonecharioteer
Copy link
Collaborator

This is to address this Pull Request's review notes. There needs to be a way to disable the docker build steps. This isn't straightforward sadly, since it is not possible right now to detect whether cargo is running build or test. So I think we can either do this using an environment variable (I'm strongly leaning towards this), or to write a Makefile (I hate makefiles, and they get complicated way too fast.

@noot the two options would be:

BUILD_DOCKER=1 cargo test

or

make tests

I think the first option will be cleaner and simpler to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant