From 7cd32a92f903b6d23fb1d5bf88aa6e5d0bb3e344 Mon Sep 17 00:00:00 2001 From: Julien Eluard Date: Thu, 25 Apr 2024 12:57:23 +0200 Subject: [PATCH 1/4] feat: add arm64 binary support --- .github/workflows/binaries.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/binaries.yml b/.github/workflows/binaries.yml index 975c2abf6f34..29b13786a8ab 100644 --- a/.github/workflows/binaries.yml +++ b/.github/workflows/binaries.yml @@ -19,9 +19,11 @@ jobs: matrix: include: - os: ubuntu-latest - build: | - npx caxa -m "Unpacking Lodestar binary, please wait..." -e "dashboards/**" -e "docs/**" -D -p "yarn install --frozen-lockfile --production" --input . --output "lodestar" -- "{{caxa}}/node_modules/.bin/node" "--max-old-space-size=8192" "{{caxa}}/node_modules/.bin/lodestar" - tar -czf "dist/lodestar-${{ inputs.version }}-linux-amd64.tar.gz" "lodestar" + platform: linux + arch: amd64 + - os: lodestar-arm64-runner + platform: linux + arch: arm64 runs-on: ${{matrix.os}} steps: - uses: actions/checkout@v4 @@ -31,7 +33,8 @@ jobs: - run: | mkdir -p dist yarn global add caxa@3.0.1 - ${{ matrix.build }} + npx caxa -m "Unpacking Lodestar binary, please wait..." -e "dashboards/**" -e "docs/**" -D -p "yarn install --frozen-lockfile --production" --input . --output "lodestar" -- "{{caxa}}/node_modules/.bin/node" "--max-old-space-size=8192" "{{caxa}}/node_modules/.bin/lodestar" + tar -czf "dist/lodestar-${{ inputs.version }}-${{ matrix.platform }}-${{ matrix.arch }}.tar.gz" "lodestar" - name: Upload binaries uses: actions/upload-artifact@v4 with: From 46ada0a827645c1e8c10af7d64fbf241cf9ab1ba Mon Sep 17 00:00:00 2001 From: Julien Eluard Date: Thu, 25 Apr 2024 14:11:54 +0200 Subject: [PATCH 2/4] chore: workaround yarn --- .github/workflows/binaries.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/binaries.yml b/.github/workflows/binaries.yml index 29b13786a8ab..8ab92ea641b9 100644 --- a/.github/workflows/binaries.yml +++ b/.github/workflows/binaries.yml @@ -27,6 +27,13 @@ jobs: runs-on: ${{matrix.os}} steps: - uses: actions/checkout@v4 + - name: Install yarn + if: matrix.arch == 'arm64' + run: |- + curl -fsSL --create-dirs -o $HOME/bin/yarn \ + https://github.com/yarnpkg/yarn/releases/download/v1.22.22/yarn-1.22.22.js + chmod +x $HOME/bin/yarn + echo "$HOME/bin" >> $GITHUB_PATH - uses: "./.github/actions/setup-and-build" with: node: 20 From 5da8959741580bfa7db2cd2a0dbdb724d0c59626 Mon Sep 17 00:00:00 2001 From: Julien Eluard Date: Thu, 25 Apr 2024 16:01:56 +0200 Subject: [PATCH 3/4] chore: add comment --- .github/workflows/binaries.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/binaries.yml b/.github/workflows/binaries.yml index 8ab92ea641b9..1bd86ee0c77a 100644 --- a/.github/workflows/binaries.yml +++ b/.github/workflows/binaries.yml @@ -27,6 +27,8 @@ jobs: runs-on: ${{matrix.os}} steps: - uses: actions/checkout@v4 + # Install yarn for arm64 as currently it's not part of the provided image + # See https://github.com/github-early-access/arm-runners-beta/issues/5 - name: Install yarn if: matrix.arch == 'arm64' run: |- From 52de601db8d5ef14eba5baf26a86aa4dae9ad174 Mon Sep 17 00:00:00 2001 From: Julien Eluard Date: Fri, 26 Apr 2024 14:35:26 +0200 Subject: [PATCH 4/4] chore: workaround runner limitations --- .github/workflows/binaries.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/binaries.yml b/.github/workflows/binaries.yml index 1bd86ee0c77a..da9063438859 100644 --- a/.github/workflows/binaries.yml +++ b/.github/workflows/binaries.yml @@ -27,15 +27,18 @@ jobs: runs-on: ${{matrix.os}} steps: - uses: actions/checkout@v4 - # Install yarn for arm64 as currently it's not part of the provided image - # See https://github.com/github-early-access/arm-runners-beta/issues/5 - - name: Install yarn + - name: Install arm64 specifics if: matrix.arch == 'arm64' run: |- + # Install missing yarn + # See https://github.com/github-early-access/arm-runners-beta/issues/5 curl -fsSL --create-dirs -o $HOME/bin/yarn \ https://github.com/yarnpkg/yarn/releases/download/v1.22.22/yarn-1.22.22.js chmod +x $HOME/bin/yarn echo "$HOME/bin" >> $GITHUB_PATH + # Install missing build-essential + sudo apt-get update + sudo apt-get install -y build-essential - uses: "./.github/actions/setup-and-build" with: node: 20