diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index af2acd5f1a79..643e5824a73d 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -32,7 +32,7 @@ jobs: node-version: 18 - name: Node.js version id: node - run: echo "::set-output name=v8CppApiVersion::$(node --print "process.versions.modules")" + run: echo "v8CppApiVersion=$(node --print "process.versions.modules")" >> $GITHUB_OUTPUT - name: Restore dependencies uses: actions/cache@master id: cache-deps diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index b012f20cea54..06d48b14940c 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -16,7 +16,7 @@ jobs: node-version: 18 - name: Node.js version id: node - run: echo "::set-output name=v8CppApiVersion::$(node --print "process.versions.modules")" + run: echo "v8CppApiVersion=$(node --print "process.versions.modules")" >> $GITHUB_OUTPUT - name: Restore dependencies uses: actions/cache@master id: cache-deps diff --git a/.github/workflows/publish-dev.yml b/.github/workflows/publish-dev.yml index ae640d79755d..2dc072ccb234 100644 --- a/.github/workflows/publish-dev.yml +++ b/.github/workflows/publish-dev.yml @@ -24,7 +24,7 @@ jobs: registry-url: "https://registry.npmjs.org" - name: Node.js version id: node - run: echo "::set-output name=v8CppApiVersion::$(node --print "process.versions.modules")" + run: echo "v8CppApiVersion=$(node --print "process.versions.modules")" >> $GITHUB_OUTPUT - name: Restore dependencies uses: actions/cache@master id: cache-deps @@ -46,7 +46,7 @@ jobs: PACKAGE_VERSION=$(node -p "require('./packages/cli/package.json').version") NEXT_VERSION=$(npx --yes semver --increment minor $PACKAGE_VERSION) export VERSION=${NEXT_VERSION}-dev.${GITHUB_SHA:0:10} - echo "::set-output name=version::$VERSION" + echo "version=$VERSION" >> $GITHUB_OUTPUT echo PACKAGE_VERSION $PACKAGE_VERSION GITHUB_SHA $GITHUB_SHA VERSION $VERSION - name: Change and commit version diff --git a/.github/workflows/publish-rc.yml b/.github/workflows/publish-rc.yml index 5d79111fea0c..462753d3e871 100644 --- a/.github/workflows/publish-rc.yml +++ b/.github/workflows/publish-rc.yml @@ -21,7 +21,7 @@ jobs: - name: Get tag id: get_tag - run: echo ::set-output name=tag::${GITHUB_REF/refs\/tags\//} + run: echo "tag=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_OUTPUT - name: Get previous tag id: get_prev_tag @@ -57,7 +57,7 @@ jobs: node-version: 18 - name: Node.js version id: node - run: echo "::set-output name=v8CppApiVersion::$(node --print "process.versions.modules")" + run: echo "v8CppApiVersion=$(node --print "process.versions.modules")" >> $GITHUB_OUTPUT - name: Restore dependencies uses: actions/cache@master id: cache-deps diff --git a/.github/workflows/publish-stable.yml b/.github/workflows/publish-stable.yml index 16a0ed126ea9..7047644b08ff 100644 --- a/.github/workflows/publish-stable.yml +++ b/.github/workflows/publish-stable.yml @@ -21,7 +21,7 @@ jobs: - name: Get tag id: get_tag - run: echo ::set-output name=tag::${GITHUB_REF/refs\/tags\//} + run: echo "tag=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_OUTPUT - name: Assert tag == package.json version run: .github/workflows/scripts/assert-same-package-version.sh @@ -40,8 +40,8 @@ jobs: run: | STABLE_COMMIT=$(git log --pretty="%h" -n 1 refs/remotes/origin/stable) TAG_COMMIT=$(git log --pretty="%h" -n 1 $GITHUB_REF) - echo ::set-output name=stable_commit::$STABLE_COMMIT - echo ::set-output name=tag_commit::$TAG_COMMIT + echo "stable_commit=$STABLE_COMMIT" >> $GITHUB_OUTPUT + echo "tag_commit=$TAG_COMMIT" >> $GITHUB_OUTPUT outputs: is_stable: ${{ steps.release_type.outputs.stable_commit == steps.release_type.outputs.tag_commit }} @@ -63,7 +63,7 @@ jobs: node-version: 18 - name: Node.js version id: node - run: echo "::set-output name=v8CppApiVersion::$(node --print "process.versions.modules")" + run: echo "v8CppApiVersion=$(node --print "process.versions.modules")" >> $GITHUB_OUTPUT - name: Restore dependencies uses: actions/cache@master id: cache-deps diff --git a/.github/workflows/test-browser.yml b/.github/workflows/test-browser.yml index d60dfae76b66..16b69b406f48 100644 --- a/.github/workflows/test-browser.yml +++ b/.github/workflows/test-browser.yml @@ -1,8 +1,8 @@ name: Browser tests -on: +on: push: - # We intentionally don't run push on feature branches. See PR for rational. + # We intentionally don't run push on feature branches. See PR for rational. branches: [unstable, stable] pull_request: workflow_dispatch: @@ -26,7 +26,7 @@ jobs: node-version: ${{matrix.node}} - name: Node.js version id: node - run: echo "::set-output name=v8CppApiVersion::$(node --print "process.versions.modules")" + run: echo "v8CppApiVersion=$(node --print "process.versions.modules")" >> $GITHUB_OUTPUT - name: Restore dependencies uses: actions/cache@master id: cache-deps diff --git a/.github/workflows/test-e2e.yml b/.github/workflows/test-e2e.yml index 7150fbf114b7..7cd1a7ce5da9 100644 --- a/.github/workflows/test-e2e.yml +++ b/.github/workflows/test-e2e.yml @@ -1,8 +1,8 @@ name: E2E tests -on: +on: push: - # We intentionally don't run push on feature branches. See PR for rational. + # We intentionally don't run push on feature branches. See PR for rational. branches: [unstable, stable] pull_request: workflow_dispatch: @@ -26,7 +26,7 @@ jobs: node-version: ${{matrix.node}} - name: Node.js version id: node - run: echo "::set-output name=v8CppApiVersion::$(node --print "process.versions.modules")" + run: echo "v8CppApiVersion=$(node --print "process.versions.modules")" >> $GITHUB_OUTPUT - name: Restore dependencies uses: actions/cache@master id: cache-deps diff --git a/.github/workflows/test-sim-merge.yml b/.github/workflows/test-sim-merge.yml index 31532d2c6b1a..a5cd4dbae7f9 100644 --- a/.github/workflows/test-sim-merge.yml +++ b/.github/workflows/test-sim-merge.yml @@ -1,8 +1,8 @@ name: Sim merge execution/builder tests -on: +on: push: - # We intentionally don't run push on feature branches. See PR for rational. + # We intentionally don't run push on feature branches. See PR for rational. branches: [unstable, stable] pull_request: workflow_dispatch: @@ -27,7 +27,7 @@ jobs: node-version: 18 - name: Node.js version id: node - run: echo "::set-output name=v8CppApiVersion::$(node --print "process.versions.modules")" + run: echo "v8CppApiVersion=$(node --print "process.versions.modules")" >> $GITHUB_OUTPUT - name: Restore dependencies uses: actions/cache@master id: cache-deps @@ -89,7 +89,7 @@ jobs: name: debug-test-logs path: packages/beacon-node/test-logs - - name: Pull geth withdrawals + - name: Pull geth withdrawals run: docker pull $GETH_WITHDRAWALS_IMAGE - name: Test Lodestar <> geth withdrawals @@ -99,7 +99,7 @@ jobs: EL_BINARY_DIR: ${{ env.GETH_WITHDRAWALS_IMAGE }} EL_SCRIPT_DIR: gethdocker - - name: Pull ethereumjs withdrawals + - name: Pull ethereumjs withdrawals run: docker pull $ETHEREUMJS_WITHDRAWALS_IMAGE - name: Test Lodestar <> ethereumjs withdrawals diff --git a/.github/workflows/test-sim.yml b/.github/workflows/test-sim.yml index 9bba2a0cfb2d..a5cae2cb5440 100644 --- a/.github/workflows/test-sim.yml +++ b/.github/workflows/test-sim.yml @@ -23,7 +23,7 @@ jobs: node-version: 18 - name: Node.js version id: node - run: echo "::set-output name=v8CppApiVersion::$(node --print "process.versions.modules")" + run: echo "v8CppApiVersion=$(node --print "process.versions.modules")" >> $GITHUB_OUTPUT - name: Restore dependencies uses: actions/cache@master id: cache-deps diff --git a/.github/workflows/test-spec.yml b/.github/workflows/test-spec.yml index 80d3331b7109..24f8d0aa7890 100644 --- a/.github/workflows/test-spec.yml +++ b/.github/workflows/test-spec.yml @@ -22,7 +22,7 @@ jobs: node-version: 18 - name: Node.js version id: node - run: echo "::set-output name=v8CppApiVersion::$(node --print "process.versions.modules")" + run: echo "v8CppApiVersion=$(node --print "process.versions.modules")" >> $GITHUB_OUTPUT - name: Restore dependencies uses: actions/cache@master id: cache-deps diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 7927ce9fb17f..405463e2f751 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -23,7 +23,7 @@ jobs: node-version: ${{matrix.node}} - name: Node.js version id: node - run: echo "::set-output name=v8CppApiVersion::$(node --print "process.versions.modules")" + run: echo "v8CppApiVersion=$(node --print "process.versions.modules")" >> $GITHUB_OUTPUT - name: Restore dependencies uses: actions/cache@master id: cache-deps diff --git a/scripts/release/assert_valid_rc.mjs b/scripts/release/assert_valid_rc.mjs deleted file mode 100644 index dc1141c9f9a3..000000000000 --- a/scripts/release/assert_valid_rc.mjs +++ /dev/null @@ -1,44 +0,0 @@ -/* eslint-disable - no-console, - @typescript-eslint/no-unsafe-assignment, - @typescript-eslint/no-unsafe-member-access, - @typescript-eslint/no-unsafe-call, - import/no-extraneous-dependencies -*/ - -import semver from "semver"; - -import {assertCommitExistsInBranch} from "./utils.mjs"; - -// Asserts whether a tag is a valid release candidate or not -// This script is meant to be run by a github workflow -// The output of this script is to either set github variables or not - -const tag = process.env.TAG; -const commit = tag; - -console.log("Tag:", tag); - -// assert it matches proper format vX.X.X-rc.X -const version = semver.parse(tag); -if (!version) { - console.log("Invalid tag: unparseable version"); - process.exit(); -} -if (version.prerelease.length !== 2 && version.prerelease[0] !== "rc" && !Number.isInteger(version.prerelease[1])) { - console.log("Invalid tag: not a valid rc version"); - process.exit(); -} - -// assert it exists in branch rc/vX.X.X -const rcBranch = `rc/v${version.major}.${version.minor}.${version.patch}`; -try { - assertCommitExistsInBranch(commit, rcBranch); -} catch (e) { - console.log("Invalid commit: does not exist in rc branch", rcBranch); - process.exit(); -} - -// success -console.log("::set-output name=is_rc::true"); -console.log(`::set-output name=version::${version.version}`); diff --git a/scripts/release/assert_valid_rc.sh b/scripts/release/assert_valid_rc.sh index f1e435f1d9e1..837af22b61a8 100755 --- a/scripts/release/assert_valid_rc.sh +++ b/scripts/release/assert_valid_rc.sh @@ -24,5 +24,5 @@ HEAD_COMMIT=$(git rev-parse refs/remotes/origin/$RC_BRANCH) git merge-base --is-ancestor $COMMIT $HEAD_COMMIT # success -echo "::set-output name=is_rc::true" -echo "::set-output name=version::$VERSION" +echo "is_rc=true" >> $GITHUB_OUTPUT +echo "version=$VERSION" >> $GITHUB_OUTPUT