Merge pull request #2 from tuyennhv/tuyennhv/rewards-api

ensi321 · web-flow · commit eceea0284b24 · 2024-02-20T11:26:11.000+08:00
fix: clone states to compute block rewards
diff --git a/packages/beacon-node/src/chain/chain.ts b/packages/beacon-node/src/chain/chain.ts
@@ -1001,6 +1001,6 @@ export class BeaconChain implements IBeaconChain {
       throw Error(`Pre-state is unavailable given block's parent root ${toHexString(block.parentRoot)}`);
     }
 
-    return computeBlockRewards(block, preState, postState);
+    return computeBlockRewards(block, preState.clone(), postState?.clone());
   }
 }
diff --git a/packages/beacon-node/src/chain/rewards/blockRewards.ts b/packages/beacon-node/src/chain/rewards/blockRewards.ts
@@ -94,6 +94,7 @@ function computeSyncAggregateReward(block: altair.BeaconBlock, preState: CachedB
     return 0; // phase0 block does not have syncAggregate
   }
 }
+
 /**
  * Calculate rewards received by block proposer for including proposer slashings.
  * All proposer slashing rewards go to block proposer and none to whistleblower as of Deneb

Original file line number	Diff line number	Diff line change
`@@ -1001,6 +1001,6 @@ export class BeaconChain implements IBeaconChain {`
`1001`	`1001`	throw Error(`Pre-state is unavailable given block's parent root ${toHexString(block.parentRoot)}`);
`1002`	`1002`	`}`
`1003`	`1003`
`1004`		`- return computeBlockRewards(block, preState, postState);`
	`1004`	`+ return computeBlockRewards(block, preState.clone(), postState?.clone());`
`1005`	`1005`	`}`
`1006`	`1006`	`}`
Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,7 @@ function computeSyncAggregateReward(block: altair.BeaconBlock, preState: CachedB`
`94`	`94`	`return 0; // phase0 block does not have syncAggregate`
`95`	`95`	`}`
`96`	`96`	`}`
	`97`	`+`
`97`	`98`	`/**`
`98`	`99`	`* Calculate rewards received by block proposer for including proposer slashings.`
`99`	`100`	`* All proposer slashing rewards go to block proposer and none to whistleblower as of Deneb`