From 75ea8b693dc7874f61e1f1afdb04fc2625f7b922 Mon Sep 17 00:00:00 2001 From: noot Date: Wed, 12 Jan 2022 11:25:41 -0500 Subject: [PATCH 1/3] cleanup logs if failed to get parent --- dot/sync/chain_processor.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dot/sync/chain_processor.go b/dot/sync/chain_processor.go index f45ab8e9a7..122257afb3 100644 --- a/dot/sync/chain_processor.go +++ b/dot/sync/chain_processor.go @@ -83,17 +83,19 @@ func (s *chainProcessor) processReadyBlocks() { } if err := s.processBlockData(bd); err != nil { - logger.Errorf("block data processing for block with hash %s failed: %s", bd.Hash, err) - // depending on the error, we might want to save this block for later if errors.Is(err, errFailedToGetParent) { + logger.Tracef("block data processing for block with hash %s failed: %s", bd.Hash, err) if err := s.pendingBlocks.addBlock(&types.Block{ Header: *bd.Header, Body: *bd.Body, }); err != nil { logger.Debugf("failed to re-add block to pending blocks: %s", err) } + continue } + + logger.Errorf("block data processing for block with hash %s failed: %s", bd.Hash, err) } } } From 11d2509ce7184f851e954fc94073e78af61c032d Mon Sep 17 00:00:00 2001 From: noot Date: Wed, 12 Jan 2022 16:58:12 -0500 Subject: [PATCH 2/3] change other err log to debug --- dot/sync/chain_processor.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dot/sync/chain_processor.go b/dot/sync/chain_processor.go index 122257afb3..eebdb2bb5e 100644 --- a/dot/sync/chain_processor.go +++ b/dot/sync/chain_processor.go @@ -169,7 +169,7 @@ func (s *chainProcessor) processBlockData(bd *types.BlockData) error { } if err := s.handleBlock(block); err != nil { - logger.Errorf("failed to handle block number %s: %s", block.Header.Number, err) + logger.Debugf("failed to handle block number %s: %s", block.Header.Number, err) return err } From 3c0232e8f41035d280af7450c441cf308732f119 Mon Sep 17 00:00:00 2001 From: noot Date: Thu, 13 Jan 2022 14:04:15 -0500 Subject: [PATCH 3/3] update indents --- dot/sync/chain_processor.go | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/dot/sync/chain_processor.go b/dot/sync/chain_processor.go index eebdb2bb5e..430c8ddc53 100644 --- a/dot/sync/chain_processor.go +++ b/dot/sync/chain_processor.go @@ -84,18 +84,18 @@ func (s *chainProcessor) processReadyBlocks() { if err := s.processBlockData(bd); err != nil { // depending on the error, we might want to save this block for later - if errors.Is(err, errFailedToGetParent) { - logger.Tracef("block data processing for block with hash %s failed: %s", bd.Hash, err) - if err := s.pendingBlocks.addBlock(&types.Block{ - Header: *bd.Header, - Body: *bd.Body, - }); err != nil { - logger.Debugf("failed to re-add block to pending blocks: %s", err) - } + if !errors.Is(err, errFailedToGetParent) { + logger.Errorf("block data processing for block with hash %s failed: %s", bd.Hash, err) continue } - logger.Errorf("block data processing for block with hash %s failed: %s", bd.Hash, err) + logger.Tracef("block data processing for block with hash %s failed: %s", bd.Hash, err) + if err := s.pendingBlocks.addBlock(&types.Block{ + Header: *bd.Header, + Body: *bd.Body, + }); err != nil { + logger.Debugf("failed to re-add block to pending blocks: %s", err) + } } } }